Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design meeting: Float semantics (RFC 3514) #273

Closed
traviscross opened this issue Jun 12, 2024 · 2 comments
Closed

Design meeting: Float semantics (RFC 3514) #273

traviscross opened this issue Jun 12, 2024 · 2 comments
Labels
meeting-proposal Proposal for a lang team design meeting T-lang

Comments

@traviscross
Copy link
Contributor

Summary

We'll meet to discuss float semantics.

Background reading

About this issue

This issue corresponds to a lang-team design meeting proposal. It corresponds to a possible topic of discussion that may be scheduled for deeper discussion during one of our design meetings.

cc @RalfJung

@pnkfelix
Copy link
Member

(the reason I cc'ed this issue from rust-lang/rust#124364 is that I wanted to ensure that this comment from Ralf does not get overlooked in that meeting: rust-lang/rust#124364 (comment); some relevant quotes below.)

If LLVM assumes float operations are deterministic then indeed it must not do any const-folding that differs from the effective runtime behavior.

Non-deterministic NaNs can cause miscompilations.

@RalfJung
Copy link
Member

Non-deterministic NaNs can cause miscompilations.

This part got fixed in llvm/llvm-project#90942.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting-proposal Proposal for a lang team design meeting T-lang
Projects
Development

No branches or pull requests

3 participants