Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libc should expose program header flag constants #1876

Closed
vext01 opened this issue Aug 24, 2020 · 1 comment · Fixed by #2897
Closed

libc should expose program header flag constants #1876

vext01 opened this issue Aug 24, 2020 · 1 comment · Fixed by #2897
Labels
A-CI Area: CI-related items O-linux

Comments

@vext01
Copy link

vext01 commented Aug 24, 2020

It'd be useful if libc exposed PF_X, PF_R, PF_W and PF_MASKPROC.

You can currently get PF_{R,W,X} from the elf crate, but arguably libc is a more appropriate home for them and PF_MASKPROC should also be included.
@vext01 vext01 mentioned this issue Aug 24, 2020
Merged
@joshtriplett
Copy link
Member

Given that these flags exist in glibc's elf.h, these seem completely reasonable to add to the libc crate. Could you send a pull request adding them?

@JohnTitor JohnTitor added A-CI Area: CI-related items O-linux labels Oct 14, 2020
@paandahl paandahl mentioned this issue Sep 3, 2022
Merged
bors added a commit that referenced this issue Sep 5, 2022
@bors
Auto merge of #2897 - paandahl:add-elf-constants, r=JohnTitor
698fbdb 
Added missing constants from elf.h

I have added a bunch of constants from elf.h, useful for parsing ELF files.

Closes #1876
@bors bors closed this as completed in 6b36b18 Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-CI Area: CI-related items O-linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added missing constants from elf.h paandahl/libc
3 participants
@joshtriplett @vext01 @JohnTitor