Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add definitions for Linux debug related MAGIC #1943

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Add definitions for Linux debug related MAGIC #1943

merged 1 commit into from
Oct 20, 2020

Conversation

KentaTada
Copy link
Contributor

This commit adds definitions for Linux debug related MAGIC to confirm if the filesystem for debug is mounted.

Signed-off-by: Kenta Tada Kenta.Tada@sony.com

Add definitions for Linux debug related MAGIC
8b68710 
Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

JohnTitor
JohnTitor approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2020

📌 Commit 8b68710 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Oct 20, 2020

⌛ Testing commit 8b68710 with merge a400a97...

bors added a commit that referenced this pull request Oct 20, 2020
@bors
Auto merge of #1943 - KentaTada:add-debug-related-magic, r=JohnTitor
a400a97 
Add definitions for Linux debug related MAGIC

This commit adds definitions for Linux debug related MAGIC to confirm if the filesystem for debug is mounted.

Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
@bors
Copy link
Contributor

bors commented Oct 20, 2020

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

Ugh, MIPS64 uses too many resources in normal testing as well. I'll disable it shortly, one sec.

@JohnTitor
Copy link
Member

@bors retry

bors added a commit that referenced this pull request Oct 20, 2020
@bors
Auto merge of #1943 - KentaTada:add-debug-related-magic, r=JohnTitor
b24b1a5 
Add definitions for Linux debug related MAGIC

This commit adds definitions for Linux debug related MAGIC to confirm if the filesystem for debug is mounted.

Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
@bors
Copy link
Contributor

bors commented Oct 20, 2020

⌛ Testing commit 8b68710 with merge b24b1a5...

@JohnTitor JohnTitor mentioned this pull request Oct 20, 2020
Merged
@JohnTitor
Copy link
Member

@bors retry yielding

@bors
Copy link
Contributor

bors commented Oct 20, 2020

@JohnTitor: 🔑 Insufficient privileges: not in try users

@JohnTitor
Copy link
Member

@bors retry

bors added a commit that referenced this pull request Oct 20, 2020
@bors
Auto merge of #1946 - JohnTitor:rollup-66245hd, r=JohnTitor
2995d71 
Rollup of 3 pull requests

Successful merges:

 - #1943 (Add definitions for Linux debug related MAGIC)
 - #1944 (Include sendfile64() for Linux)
 - #1945 (Disable libc-test for MIPS64 for now)

Failed merges:

r? `@ghost`
@bors bors merged commit fd266e0 into rust-lang:master Oct 20, 2020
@bors
Copy link
Contributor

bors commented Oct 20, 2020

⌛ Testing commit 8b68710 with merge 2995d71...

@KentaTada KentaTada mentioned this pull request Oct 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KentaTada @rust-highfive @JohnTitor @bors