Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendfile
uses theoff_t
type, which is platform dependent. On 64-bit architectures, I can pass anoff64_t
as the third argument tolibc::sendfile
, but on 32-bit architectures, this does not compile.sendfile64
on the other hand uses a 64-bit wide offset even on 32-bit architectures, so thatoff64_t
can be used.Excerpt from
man 2 sendfile
:I hope that supporting Linux versions below 2.4 is not a requirement for libc.