Fix/remove deprecated DragonFly items #2522
Conversation
These items were recently deprecated on DragonFly, either because the platform does not define them or because they were out of date.
|
r? @JohnTitor (rust-highfive has picked a reviewer for you, use r? to override) |
|
I'm not sure how long the maintainers prefer to wait after deprecating items before fixing them, but I thought I'd put a PR up now and let the maintainers merge it when they felt it was appropriate. My hope is that it can be merged without waiting too many releases, since DragonFly is a tier 3 target for rust. |
|
I think about a month is enough, maybe? Looking at the download stats on https://crates.io/crates/libc, some of the active users have updated but right now is a bit early, I feel. |
libc::stat is deprecated on DragonflyBSD in libc. But there isn't any alternative yet, so Nix must simply suppress the warnings. It's used in too many places to suppress each one individually, so just suppress all deprecation warnings globally until it's properly fixed. rust-lang/libc#2522
|
@JohnTitor it's been a little under a month (~4 weeks), but based on the download stats it looks like we're likely reaching the point of diminishing returns. I don't see any open PRs calling for a new release (suggesting the next one is at least a few days away); are we at a point where this can be merged? |
|
Okay, let's assume most active users should've got the deprecation note, @bors r+ |
|
📌 Commit 45cd3dc has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
These items were recently deprecated on DragonFly, either because the platform does not define them or because they were out of date.