-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freebsd kinfo_kstat/sigtramp additions #2766
Conversation
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
@bors r+ |
📌 Commit 6fe5534 has been approved by |
freebsd kinfo_kstat/sigtramp additions
💔 Test failed - checks-actions |
6fe5534
to
7050eae
Compare
pub struct kinfo_kstack { | ||
pub kkst_tid: ::lwpid_t, | ||
pub kkst_state: ::c_int, | ||
pub kkst_trace: [[::c_char; 32]; 32], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather keep the original size and just use a cfg()
to only make this type available on newer rustc versions.
7050eae
to
e29e642
Compare
@bors r+ |
📌 Commit e29e642 has been approved by |
@bors r- |
Wait, this isn't the right cfg. It seems that we don't have one for this specific feature. Basically in 1.47 most traits were updated to be implemented for arrays of any length. Add a new cfg in build.rs for this. |
ah ok will do :) |
e29e642
to
4b61ce8
Compare
@bors r+ |
📌 Commit 4b61ce8 has been approved by |
freebsd kinfo_kstat/sigtramp additions
💔 Test failed - checks-cirrus-freebsd-11 |
@bors retry |
freebsd kinfo_kstat/sigtramp additions
💔 Test failed - checks-actions |
To revive the logs, @bors try |
freebsd kinfo_kstat/sigtramp additions
💔 Test failed - checks-actions |
4b61ce8
to
1d20fd1
Compare
@bors r+ |
freebsd kinfo_kstat/sigtramp additions
💔 Test failed - checks-actions |
☔ The latest upstream changes (presumably #3101) made this pull request unmergeable. Please resolve the merge conflicts. |
@devnexen Are you still working on this? |
No I do not think so. |
No description provided.