ucontext usage update on macos 64 bits. #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
devnexen
force-pushed
the
macos_arm64_context_upd
branch
2 times, most recently
from
ed28db1
to
15a88f3
Compare
JohnTitor
reviewed
Jun 5, 2022
src/unix/bsd/apple/b64/mod.rs
Outdated
| @@ -109,6 +109,9 @@ extern "C" { | |||
| path2: *const ::c_char, | |||
| options: ::c_uint, | |||
| ) -> ::c_int; | |||
|
|
|||
| #[allow(deprecated)] | |||
libc-test/build.rs
Outdated
Comment on lines
327
to
328
| // deprecated api | ||
| "getcontext" => true, |
There was a problem hiding this comment.
I'm not sure if adding a deprecated API is a good idea. If there are no good alternatives, users should report it upstream, adding it here just delays the problem.
There was a problem hiding this comment.
I hesitated to be honest.
There was a problem hiding this comment.
There isn't any good alternative afaik, and I'm not sure if Apple cares about low-level APIs enough to provide one
There was a problem hiding this comment.
My concern is that deprecated items are likely to be removed, i.e. they would introduce a breaking change. Such a code should belong to userland IMHO.
There was a problem hiding this comment.
@devnexen By the way, we don't have to ignore it on the test anymore, right?
devnexen
force-pushed
the
macos_arm64_context_upd
branch
from
15a88f3
to
0e2e142
Compare
devnexen
force-pushed
the
macos_arm64_context_upd
branch
from
0e2e142
to
2d11246
Compare
JohnTitor
approved these changes
Jun 7, 2022
|
Thanks! |
|
📌 Commit 2d11246 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 7, 2022
ucontext usage update on macos 64 bits. closes #2812
|
💔 Test failed - checks-actions |
|
crates.io failure @bors retry |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
bors
pushed a commit
that referenced
this pull request
Aug 15, 2023
This commit effectively reverts #2817. Currently `ucontext_t` has both the wrong size and the wrong alignment for aarch64-apple-darwin which causes problems for users referencing the structure [1]. The issue linked from #2817 claimed that it fixed #2812 but that's still an issue where FFI warnings are still emitted for usage of `ucontext_t` due to its transitive usage of `u128`. I'm not sure how to fix #2812 myself, but given that #2817 doesn't appear to solve its original intent and additionally the size/align are currently wrong this commit reverts in the meantime. [1]: bytecodealliance/wasmtime#6785 (comment)
bors
added a commit
that referenced
this pull request
Aug 15, 2023
…ohnTitor Fix size/align of `ucontext_t` on aarch64-apple-darwin This commit effectively reverts #2817. Currently `ucontext_t` has both the wrong size and the wrong alignment for aarch64-apple-darwin which causes problems for users referencing the structure [1]. The issue linked from #2817 claimed that it fixed #2812 but that's still an issue where FFI warnings are still emitted for usage of `ucontext_t` due to its transitive usage of `u128`. I'm not sure how to fix #2812 myself, but given that #2817 doesn't appear to solve its original intent and additionally the size/align are currently wrong this commit reverts in the meantime. [1]: bytecodealliance/wasmtime#6785 (comment)
bors
added a commit
that referenced
this pull request
Aug 17, 2023
…ohnTitor Fix size/align of `ucontext_t` on aarch64-apple-darwin This commit effectively reverts #2817. Currently `ucontext_t` has both the wrong size and the wrong alignment for aarch64-apple-darwin which causes problems for users referencing the structure [1]. The issue linked from #2817 claimed that it fixed #2812 but that's still an issue where FFI warnings are still emitted for usage of `ucontext_t` due to its transitive usage of `u128`. I'm not sure how to fix #2812 myself, but given that #2817 doesn't appear to solve its original intent and additionally the size/align are currently wrong this commit reverts in the meantime. [1]: bytecodealliance/wasmtime#6785 (comment)
xevor11
pushed a commit
to xevor11/libc
that referenced
this pull request
Aug 25, 2023
This commit effectively reverts rust-lang#2817. Currently `ucontext_t` has both the wrong size and the wrong alignment for aarch64-apple-darwin which causes problems for users referencing the structure [1]. The issue linked from rust-lang#2817 claimed that it fixed rust-lang#2812 but that's still an issue where FFI warnings are still emitted for usage of `ucontext_t` due to its transitive usage of `u128`. I'm not sure how to fix rust-lang#2812 myself, but given that rust-lang#2817 doesn't appear to solve its original intent and additionally the size/align are currently wrong this commit reverts in the meantime. [1]: bytecodealliance/wasmtime#6785 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2812