Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cirrus-ci: use matrix to remove redundant parts on building BSDs #3719

Merged
merged 1 commit into from
Jun 16, 2024
Merged

cirrus-ci: use matrix to remove redundant parts on building BSDs #3719

merged 1 commit into from
Jun 16, 2024

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented May 23, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented May 23, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

asomers
asomers approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to include the name: field in the matrix. Otherwise, LGTM.

@tesuji tesuji force-pushed the ci-cirrus-cache branch 4 times, most recently from 0cde683 to bc1fe32 Compare May 31, 2024 02:20
@tesuji
Copy link
Contributor Author

tesuji commented May 31, 2024

This should be done now!
image

@JohnTitor JohnTitor enabled auto-merge June 16, 2024 11:06
@JohnTitor JohnTitor added this pull request to the merge queue Jun 16, 2024
Merged via the queue into rust-lang:libc-0.2 with commit 1a9c8f7 Jun 16, 2024
57 checks passed
@tesuji tesuji deleted the ci-cirrus-cache branch July 4, 2024 02:25
@tgross35 tgross35 added the main-needs-cherry-pick This PR was merged against libc-0.2 but does not yet exist in main. label Aug 13, 2024
This was referenced Aug 15, 2024
Closed
Merged
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 29, 2024
@tesuji @tgross35
cirrus-ci: use matrix to remove redundant parts on building bsds
f88c3de 
(apply <rust-lang#3719> to `main`)
[ resolve conflicts - Trevor ]
(cherry picked from commit 1953098)
@tgross35 tgross35 mentioned this pull request Aug 29, 2024
Merged
@tgross35 tgross35 added main-applied This PR was merged against libc-0.2 and main has since been updated to include it and removed main-needs-cherry-pick This PR was merged against libc-0.2 but does not yet exist in main. labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
main-applied This PR was merged against libc-0.2 and main has since been updated to include it S-waiting-on-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tesuji @rustbot @asomers @JohnTitor @tgross35