Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests that check the line numbers #601

Closed
Thomasdezeeuw opened this issue Nov 28, 2023 · 2 comments · Fixed by #619
Closed

Add tests that check the line numbers #601

Thomasdezeeuw opened this issue Nov 28, 2023 · 2 comments · Fixed by #619

Comments

@Thomasdezeeuw
Copy link
Collaborator

We currently don't have any.
@Thomasdezeeuw Thomasdezeeuw mentioned this issue Nov 28, 2023
Closed
@DIvkov575
Copy link
Contributor

Im pretty new to contributing, but I would love to contribute to this repo. Would this be a good issue to start with?

@Thomasdezeeuw
Copy link
Collaborator Author

Im pretty new to contributing, but I would love to contribute to this repo. Would this be a good issue to start with?

Hey @DIvkov575 sorry for the delayed response, I've been traveling.

I think it will be a good first issue. I think the easiest way to get started is to look at tests/filters.rsfor inspiration. If you have a any questions or you get stuck somewhere feel free to ask!

@DIvkov575 DIvkov575 mentioned this issue Mar 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adding line_number test + updating some testing infrastructure DIvkov575/log
2 participants
@Thomasdezeeuw @DIvkov575