Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate links don't work on the print page #542

Open
Michael-F-Bryan opened this issue Jan 13, 2018 · 0 comments
Open

Duplicate links don't work on the print page #542

Michael-F-Bryan opened this issue Jan 13, 2018 · 0 comments
Labels
A-Links Area: Issues with links A-Print Area: The "printed" page

Comments

@Michael-F-Bryan
Copy link
Contributor

On rust-lang/rust-by-example#989 they found that when two pages in different chapters use the same footnote (e.g. [1]) then one will clobber the other when all chapters are concatenated to form the print page. Ideally we should be able to tweak the print page so this doesn't happen.

@projektir's original comment:

So... this one is funky. There are two pages in RBE that are attempting to use the [^1] annotation. The way pulldown-cmark does annotations is by creating a div with id equal to the annotation name (in this case, "1"). This is all well and good, until the print.html page is created, in which case this now results in two different divs with id="1", which is invalid and is a failure to the linkchecker.

I've replaced 1 here with the dagger symbol †, which looks like 1 in the fonts used by RBE, but I am not really sure how to address this issue in general since we basically can't use the 1, 2, 3 footnote style for as long as we intend to have a page that concatenates everything together.

@ehuss ehuss added A-Print Area: The "printed" page A-Links Area: Issues with links labels May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Links Area: Issues with links A-Print Area: The "printed" page
Projects
None yet
Development

No branches or pull requests

2 participants