Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up "index page" functionality #1829

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Fix up "index page" functionality #1829

merged 3 commits into from
Jun 30, 2022

Conversation

ISSOtm
Copy link
Contributor

@ISSOtm ISSOtm commented Jun 22, 2022

Additionally, I would've liked to document that "index page" functionality, but I couldn't find any place for it in the documentation.

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine to land. It seems a little strange to not have a prefix chapter like an introduction. Another option would be to create an index.html that redirects to the first chapter, though that's probably not necessary.

tests/rendered_output.rs Outdated Show resolved Hide resolved
tests/rendered_output.rs Outdated Show resolved Hide resolved
Makes both pages more consistent, and also the previous test pass

Co-authored-by: Eric Huss <eric@huss.org>
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss merged commit a10a57e into rust-lang:master Jun 30, 2022
@ISSOtm ISSOtm deleted the index branch June 30, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

index.html fails to be created silently when there is no prefix chapter
2 participants