-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SystemTime
with enabled isolation
#3740
Comments
We quite deliberately did not do that as it seemed even more confusing than the fake monotonic clock. The intended reaction to a program using (Also, it's Miri, not MIRI. ;) |
FWIW if you have a good motivation for why you want this with isolation enabled, we could be persuaded. I just stated our reasoning for not having done this already. :) |
It's just a matter of convenience. It would be nice in my opinion to have this feature, but I understand your position above. I've asked the logger crate which we use in our tests to add support for
I always thought it's an abbreviation of "Mid-level Intermediate Representation Interpreter". :) |
That is indeed the origin of the name, but we don't write it in all-caps. :) |
Right now MIRI with enabled isolation fails in code which uses
SystemTime::now()
with the following error:It means that most loggers will trigger this error. In some cases it's possible to work around this by disabling timestamps, but ideally it would work out of the box.
MIRI already has emulation of monotonic clocks. I think it could be used to emulate sytem time as well by re-interpreting the monotonic clock as UNIX timestamp, i.e. MIRI tests would see timestamps for 1970-01-01.
The text was updated successfully, but these errors were encountered: