Add Cargo.lock to git.

[the-kenny]

To make builds reproducible, projects building executables should add their Cargo.lock to their git repository. This is also noted in http://doc.crates.io/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

Doing this also makes packaging for distributions (in my case NixOS) much easier as it's guaranteed that the dependencies won't change between two builds.

[mcarton]

The main crate has both a plugin and a binary, what should we do about that?

[killercup]

@mcarton I'm fairly certain Cargo will ignore the lock file when clippy is used as a library. So the lock file would only affect cargo install clippy and manual builds.

[the-kenny]

That sounds like a nice solution :)
Am 17.06.2016 20:34 schrieb "Pascal Hertleif" notifications@github.com:

@mcarton https://github.com/mcarton I'm fairly certain Cargo will
ignore the lock file when clippy is used as a library. So the lock file
would only affect cargo install clippy and manual builds.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Manishearth/rust-clippy/issues/1019#issuecomment-226847296,
or mute the thread
https://github.com/notifications/unsubscribe/AAB5v1nF42MMyw_DINDVCPsxKuogfQo1ks5qMujPgaJpZM4I3Pdc
.

[the-kenny]

Any updates on this? I think the comment of @killercup clears the way to include Cargo.lock in the repository.

[Manishearth]

IIRC the lock file won't affect cargo install, it only affects using the library as a git clone, which is a rare use case (only clippy devs, basically). I'm not sure of this though.

[the-kenny]

As I mention in the opening description: A Cargo.lock file is crucial to get reproducible builds. This is not only useful for development (as every developer will have the same set of dependencies, which makes it easy to reproduce bugs), but also useful for people trying your package your software for distribution.

Please take a look at this and this for a detailed description of the benefits.

[Manishearth]

I know why it's useful, I was just wondering if it applied to binaries. Turns out it does, so we can go ahead with this 😄

[sanmai-NL]

@Manishearth @the-kenny: seems like a small PR is still needed to close this.

[oli-obk]

We can't do this due to the rustc integration, where we are in the rustc workspace. we used to have it but removed it during the merger