Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor 'stderr: error: unable to unlink old fallback exe' error in dogfood tests #3118

Closed
phansch opened this issue Sep 3, 2018 · 4 comments
Labels
C-bug Category: Clippy is not doing the correct thing

Comments

@phansch
Copy link
Member

phansch commented Sep 3, 2018

This error started appearing after #3115, but no idea why.

@phansch phansch added the C-bug Category: Clippy is not doing the correct thing label Sep 3, 2018
@flip1995
Copy link
Member

flip1995 commented Sep 3, 2018

Especially #3115 (comment)

@ghost
Copy link

ghost commented Sep 3, 2018

Probably what happens is... 🤔

We run cargo test and rustup links the fall back file and executes it. During the testing, dogfood calls cargo itself which causes rustup to try and replace the fallback file but it can't because cargo test is still running.

We never had this problem before because we weren't using a custom toolchain.

https://github.com/rust-lang-nursery/rustup.rs/blob/22b6cdb8b000f9217af1dd5dd4e73ce032bdb25d/src/rustup/toolchain.rs#L374

@ghost
Copy link

ghost commented Sep 5, 2018

I'm trying to fix this. See rust-lang/rustup#1499.

@ghost
Copy link

ghost commented Feb 24, 2019

We fixed this in #3701.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing
Projects
None yet
Development

No branches or pull requests

2 participants