clippy_lints: enable crate_visibility_modifier since it is used but no longer part of 2018 edition. #3150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o longer part of 2018 edition. Fixes build with rust-lang/rust#53999
|
@Manishearth @oli-obk I think the AppVeyor failure is spurious -- can we get this landed relatively quickly? We'll need this to land and update the submodule in rust-lang/rust for the edition RC release. |
|
The appveyor failure is not spurious but expected and unrelated #3118 . And Travis ci still passes anyway :) |
|
@Mark-Simulacrum you can pin Clippy version to this PR and leave comment here to not rebase the PR. |
|
I would rather not release Rust compilers that look at PR branches, especially ones not in the rust-lang-nursery repository. |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build with rust-lang/rust#53999