Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approximate known const found #36

Closed
llogiq opened this issue May 3, 2015 · 2 comments
Closed

Approximate known const found #36

llogiq opened this issue May 3, 2015 · 2 comments

Comments

@llogiq
Copy link
Contributor

llogiq commented May 3, 2015

Someone writing 3.1415 should probably use some definition of PI. We should look up other constants in the standard library.

@Manishearth
Copy link
Member

+1

@llogiq
Copy link
Contributor Author

llogiq commented May 4, 2015

Done. The implementation could be improved (for example, it could return the closest approximation instead of the first found) and the epsilon constant could be changed if we find that we match too much/too little, but it works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants