Needless pass by ref mut closure non async fn #11621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Centri3
reviewed
Oct 6, 2023
GuillaumeGomez
force-pushed
the
needless_pass_by_ref_mut-closure-non-async-fn
branch
from
a1581e0
to
6b12bcc
Compare
|
Updated! |
|
Seems like Centri3 is busy so I was recommended another reviewer. r? @blyxyas |
|
☔ The latest upstream changes (presumably #11622) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
needless_pass_by_ref_mut-closure-non-async-fn
branch
from
6b12bcc
to
800ecf5
Compare
|
Fixed conflict. |
|
☔ The latest upstream changes (presumably #11624) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
needless_pass_by_ref_mut-closure-non-async-fn
branch
from
800ecf5
to
3e6db95
Compare
|
Fixed the conflict. |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
GuillaumeGomez
deleted the
needless_pass_by_ref_mut-closure-non-async-fn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11620.
Fixes #11561.
changelog: [
needless_pass_by_ref_mut]: Correctly handle arguments moved into closure in non-async functions.r? @Centri3