Don't emit needless_pass_by_ref_mut if the variable is used in an unsafe block or function
#11624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Jarcho (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
r? @Centri3 |
GuillaumeGomez
force-pushed
the
needless_pass_by_ref_mut-unsafe-fn-block
branch
from
15d012c
to
a9c63ed
Compare
Centri3
approved these changes
Oct 6, 2023
GuillaumeGomez
force-pushed
the
needless_pass_by_ref_mut-unsafe-fn-block
branch
from
a9c63ed
to
33c6e06
Compare
|
Updated! |
Centri3
requested changes
Oct 6, 2023
GuillaumeGomez
force-pushed
the
needless_pass_by_ref_mut-unsafe-fn-block
branch
from
33c6e06
to
6e6e267
Compare
|
Updated the test and fixed the code (the unsafe check was done on the wrong |
|
Seems like Centri3 is busy so I was recommended another reviewer. r? @blyxyas |
|
☔ The latest upstream changes (presumably #11622) made this pull request unmergeable. Please resolve the merge conflicts. |
…nsafe block or function
…t emitted if variable is used in an unsafe block or function
GuillaumeGomez
force-pushed
the
needless_pass_by_ref_mut-unsafe-fn-block
branch
from
6e6e267
to
80a092c
Compare
|
Fixed conflict. |
blyxyas
reviewed
Oct 18, 2023
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11586.
Fixes #11180.
As suggested in the two issues above, this lint should not be emitted if this an unsafe function or if the argument is used in an unsafe block.
changelog: [
needless_pass_by_ref_mut]: Don't emit if the variable is used in an unsafe block or function