Stabilize 2018 edition #53999

Mark-Simulacrum · 2018-09-06T16:59:25Z

Centril · 2018-09-06T17:05:35Z

src/doc/rustdoc/src/command-line-arguments.md

+Using this flag looks like this:
+
+```bash
+$ rustdoc src/lib.rs -Z unstable-options --edition 2018


Hmm... it is stable but still using unstable-options?

rust-highfive · 2018-09-06T17:48:54Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:44:36] ....................................................................................................
[00:44:39] ....................................................................................................
[00:44:42] ........i...........................................................................................
[00:44:46] ....................................................................................................
[00:44:50] .........F...i...........i..........................................................................
[00:44:55] ....................................................................................................
[00:44:57] ....................................................................................................
[00:45:00] ....................................................................................................
[00:45:02] ....................................................................................................
---
[00:45:57] ....................................................................................................
[00:46:00] ....................................................................................................
[00:46:02] ....................................................................................................
[00:46:05] ....................................................i...............................................
[00:46:09] ...............FFF..................................................................................
[00:46:15] .......................................................................................i............
[00:46:18] ....................................................................................................
[00:46:21] ....................................................................................................
[00:46:24] ....................................................................................................
[00:46:24] ....................................................................................................
[00:46:26] ........................................i...........................................................
[00:46:26] .
[00:46:26] failures:
[00:46:26] 
[00:46:26] ---- [ui] ui/crate-in-paths.rs stdout ----
[00:46:26] diff of stderr:
[00:46:26] 
[00:46:26] 8 LL | use crate::bar::Foo;
[00:46:26] 10 
[00:46:26] - error: aborting due to previous error
[00:46:26] - error: aborting due to previous error
[00:46:26] + error[E0658]: `crate` visibility modifier is experimental (see issue #45388)
[00:46:26] +   --> $DIR/crate-in-paths.rs:16:5
[00:46:26] +    |
[00:46:26] + LL |     crate struct Foo;
[00:46:26] +    |
[00:46:26] +    |
[00:46:26] +    = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable
[00:46:26] - For more information about this error, try `rustc --explain E0425`.
[00:46:26] + error: aborting due to 2 previous errors
[00:46:26] + 
[00:46:26] + Some errors occurred: E0425, E0658.
[00:46:26] + Some errors occurred: E0425, E0658.
[00:46:26] + For more information about an error, try `rustc --explain E0425`.
[00:46:26] 14 
[00:46:26] 
[00:46:26] 
[00:46:26] The actual stderr differed from the expected stderr.
[00:46:26] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/crate-in-paths/crate-in-paths.stderr
[00:46:26] To update references, rerun the tests and pass the `--bless` flag
[00:46:26] To only update this specific test, also pass `--test-args crate-in-paths.rs`
[00:46:26] error: 1 errors occurred comparing output.
[00:46:26] status: exit code: 1
[00:46:26] status: exit code: 1
[00:46:26] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/crate-in-paths.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/crate-in-paths/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/crate-in-paths/auxiliary" "-A" "unused"
[00:46:26] ------------------------------------------
[00:46:26] 
[00:46:26] ------------------------------------------
[00:46:26] stderr:
[00:46:26] stderr:
[00:46:26] ------------------------------------------
[00:46:26] {"message":"cannot find value `Foo` in this scope","code":{"code":"E0425","explanation":"\nAn unresolved name was used.\n\nErroneous code examples:\n\n```compile_fail,E0425\nsomething_that_doesnt_exist::foo;\n// error: unresolved name `something_that_doesnt_exist::foo`\n\n// or:\n\ntrait Foo {\n    fn bar() {\n        Self; // error: unresolved name `Self`\n    }\n}\n\n// or:\n\nlet x = unknown_variable;  // error: unresolved name `unknown_variable`\n```\n\nPlease verify that the name wasn't misspelled and ensure that the\nidentifier being referred to is valid for the given situation. Example:\n\n```\nenum something_that_does_exist {\n    Foo,\n}\n```\n\nOr:\n\n```\nmod something_that_does_exist {\n    pub static foo : i32 = 0i32;\n}\n\nsomething_that_does_exist::foo; // ok!\n```\n\nOr:\n\n```\nlet unknown_variable = 12u32;\nlet x = unknown_variable; // ok!\n```\n\nIf the item is not defined in the current module, it must be imported using a\n`use` statement, like so:\n\n```\n# mod foo { pub fn bar() {} }\n# fn main() {\nuse foo::bar;\nbar();\n# }\n```\n\nIf the item you are importing is not defined in some super-module of the\ncurrent module, then it must also be declared as public (e.g., `pub fn`).\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/crate-in-paths.rs","byte_start":570,"byte_end":573,"line_start":20,"line_end":20,"column_start":5,"column_end":8,"is_primary":true,"text":[{"text":"    Foo;","highlight_start":5,"highlight_end":8}],"label":"not found in this scope","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"possible candidate is found in another module, you can import it into scope","code":null,"level":"help","spans":[{"file_name":"/checkout/src/test/ui/crate-in-paths.rs","byte_start":519,"byte_end":519,"line_start":15,"line_end":15,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"mod bar {","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":"use crate::bar::Foo;\n\n","suggestion_applicability":"Unspecified","expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0425]: cannot find value `Foo` in this scope\n  --> /checkout/src/test/ui/crate-in-paths.rs:20:5\n   |\nLL |     Foo;\n   |     ^^^ not found in this scope\nhelp: possible candidate is found in another module, you can import it into scope\n   |\nLL | use crate::bar::Foo;\n   |\n\n"}
[00:46:26] {"message":"`crate` visibility modifier is experimental (see issue #45388)","code":{"code":"E0658","explanation":"\nAn unstable feature was used.\n\nErroneous code example:\n\n```compile_fail,E658\n#[repr(u128)] // error: use of unstable library feature 'repr128'\nenum Foo {\n    Bar(u64),\n}\n```\n\nIf you're using a stable or a beta version of rustc, you won't be able to use\nany unstable features. In order to do so, please switch to a nightly version of\nrustc (by using rustup).\n\nIf you're using a nightly version of rustc, just add the corresponding feature\nto be able to use it:\n\n```\n#![feature(repr128)]\n\n#[repr(u128)] // ok!\nenum Foo {\n    Bar(u64),\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/crate-in-paths.rs","byte_start":533,"byte_end":538,"line_start":16,"line_end":16,"column_start":5,"column_end":10,"is_primary":true,"text":[{"text":"    crate struct Foo;","highlight_start":5,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"add #![feature(crate_visibility_modifier)] to the crate attributes to enable","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0658]: `crate` visibility modifier is experimental (see issue #45388)\n  --> /checkout/src/test/ui/crate-in-paths.rs:16:5\n   |\nLL |     crate struct Foo;\n   |     ^^^^^\n   |\n   = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable\n\n"}
[00:46:26] {"message":"aborting due to 2 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 2 previous errors\n\n"}
[00:46:26] {"message":"Some errors occurred: E0425, E0658.","code":null,"level":"","spans":[],"children":[],"rendered":"Some errors occurred: E0425, E0658.\n"}
[00:46:26] {"message":"For more information about an error, try `rustc --explain E0425`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about an error, try `rustc --explain E0425`.\n"}
[00:46:26] ------------------------------------------
[00:46:26] 
[00:46:26] thread '[ui] ui/crate-in-paths.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3196:9
[00:46:26] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:46:26] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:46:26] 
[00:46:26] ---- [ui] ui/rust-2018/edition-lint-fully-qualified-paths.rs stdout ----
[00:46:26] diff of stderr:
[00:46:26] 
[00:46:26] - error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
[00:46:26] -   --> $DIR/edition-lint-fully-qualified-paths.rs:30:25
[00:46:26] + error[E0658]: `crate` visibility modifier is experimental (see issue #45388)
[00:46:26] +   --> $DIR/edition-lint-fully-qualified-paths.rs:17:5
[00:46:26] 3    |
[00:46:26] - LL |     let _: <foo::Baz as ::foo::Foo>::Bar = ();
[00:46:26] -    |                         ^^^^^^^^^^ help: use `crate`: `crate::foo::Foo`
[00:46:26] + LL |     crate trait Foo {
[00:46:26] 6    |
[00:46:26] - note: lint level defined here
[00:46:26] -   --> $DIR/edition-lint-fully-qualified-paths.rs:14:9
[00:46:26] -    |
[00:46:26] -    |
[00:46:26] - LL | #![deny(absolute_paths_not_starting_with_crate)]
[00:46:26] -    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
[00:46:26] -    = note: for more information, see issue TBD
[00:46:26] -    = note: for more information, see issue TBD
[00:46:26] +    = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable
[00:46:26] 14 
[00:46:26] - error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
[00:46:26] -   --> $DIR/edition-lint-fully-qualified-paths.rs:34:13
[00:46:26] + error[E0658]: `crate` visibility modifier is experimental (see issue #45388)
[00:46:26] +   --> $DIR/edition-lint-fully-qualified-paths.rs:21:5
[00:46:26] 17    |
[00:46:26] - LL |     let _: <::foo::Baz as foo::Foo>::Bar = ();
[00:46:26] -    |             ^^^^^^^^^^ help: use `crate`: `crate::foo::Baz`
[00:46:26] + LL |     crate struct Baz { }
[00:46:26] 20    |
[00:46:26] -    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
[00:46:26] -    = note: for more information, see issue TBD
[00:46:26] -    = note: for more information, see issue TBD
[00:46:26] +    = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable
[00:46:26] 24 error: aborting due to 2 previous errors
[00:46:26] 25 
[00:46:26] 
[00:46:26] + For more information about this error, try `rustc --explain E0658`.
---
[00:46:26] diff of fixed:
[00:46:26] 
[00:46:26] 27 
[00:46:26] 28 
[00:46:26] 29 fn main() {
[00:46:26] -     let _: <foo::Baz as crate::foo::Foo>::Bar = ();
[00:46:26] +     let _: <foo::Baz as ::foo::Foo>::Bar = ();
[00:46:26] 31     //~^ ERROR absolute paths must start with
[00:46:26] 32     //~| this was previously accepted
[00:46:26] 
[00:46:26] 
[00:46:26] -     let _: <crate::foo::Baz as foo::Foo>::Bar = ();
[00:46:26] +     let _: <::foo::Baz as foo::Foo>::Bar = ();
[00:46:26] 35     //~^ ERROR absolute paths must start with
[00:46:26] 36     //~| this was previously accepted
[00:46:26] 
[00:46:26] 
[00:46:26] The actual fixed differed from the expected fixed.
[00:46:26] The actual fixed differed from the expected fixed.
[00:46:26] Actual fixed saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/edition-lint-fully-qualified-paths/edition-lint-fully-qualified-paths.fixed
[00:46:26] To update references, rerun the tests and pass the `--bless` flag
[00:46:26] To only update this specific test, also pass `--test-args rust-2018/edition-lint-fully-qualified-paths.rs`
[00:46:26] error: 2 errors occurred comparing output.
[00:46:26] status: exit code: 1
[00:46:26] status: exit code: 1
[00:46:26] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rust-2018/edition-lint-fully-qualified-paths.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/edition-lint-fully-qualified-paths/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/edition-lint-fully-qualified-paths/auxiliary" "-A" "unused"
[00:46:26] ------------------------------------------
[00:46:26] 
[00:46:26] ------------------------------------------
[00:46:26] stderr:
[00:46:26] stderr:
[00:46:26] ------------------------------------------
[00:46:26] {"message":"`crate` visibility modifier is experimental (see issue #45388)","code":{"code":"E0658","explanation":"\nAn unstable feature was used.\n\nErroneous code example:\n\n```compile_fail,E658\n#[repr(u128)] // error: use of unstable library feature 'repr128'\nenum Foo {\n    Bar(u64),\n}\n```\n\nIf you're using a stable or a beta version of rustc, you won't be able to use\nany unstable features. In order to do so, please switch to a nightly version of\nrustc (by using rustup).\n\nIf you're using a nightly version of rustc, just add the corresponding feature\nto be able to use it:\n\n```\n#![feature(repr128)]\n\n#[repr(u128)] // ok!\nenum Foo {\n    Bar(u64),\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/edition-lint-fully-qualified-paths.rs","byte_start":578,"byte_end":583,"line_start":17,"line_end":17,"column_start":5,"column_end":10,"is_primary":true,"text":[{"text":"    crate trait Foo {","highlight_start":5,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"add #![feature(crate_visibility_modifier)] to the crate attributes to enable","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0658]: `crate` visibility modifier is experimental (see issue #45388)\n  --> /checkout/src/test/ui/rust-2018/edition-lint-fully-qualified-paths.rs:17:5\n   |\nLL |     crate trait Foo {\n   |     ^^^^^\n   |\n   = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable\n\n"}
[00:46:26] {"message":"`crate` visibility modifier is experimental (see issue #45388)","code":{"code":"E0658","explanation":"\nAn unstable feature was used.\n\nErroneous code example:\n\n```compile_fail,E658\n#[repr(u128)] // error: use of unstable library feature 'repr128'\nenum Foo {\n    Bar(u64),\n}\n```\n\nIf you're using a stable or a beta version of rustc, you won't be able to use\nany unstable features. In order to do so, please switch to a nightly version of\nrustc (by using rustup).\n\nIf you're using a nightly version of rustc, just add the corresponding feature\nto be able to use it:\n\n```\n#![feature(repr128)]\n\n#[repr(u128)] // ok!\nenum Foo {\n    Bar(u64),\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/edition-lint-fully-qualified-paths.rs","byte_start":625,"byte_end":630,"line_start":21,"line_end":21,"column_start":5,"column_end":10,"is_primary":true,"text":[{"text":"    crate struct Baz { }","highlight_start":5,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"add #![feature(crate_visibility_modifier)] to the crate attributes to enable","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0658]: `crate` visibility modifier is experimental (see issue #45388)\n  --> /checkout/src/test/ui/rust-2018/edition-lint-fully-qualified-paths.rs:21:5\n   |\nLL |     crate struct Baz { }\n   |     ^^^^^\n   |\n   = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable\n\n"}
[00:46:26] {"message":"aborting due to 2 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 2 previous errors\n\n"}
[00:46:26] {"message":"For more information about this error, try `rustc --explain E0658`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0658`.\n"}
[00:46:26] ------------------------------------------
[00:46:26] 
[00:46:26] thread '[ui] ui/rust-2018/edition-lint-fully-qualified-paths.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3196:9
[00:46:26] 
[00:46:26] 
[00:46:26] ---- [ui] ui/rust-2018/edition-lint-nested-empty-paths.rs stdout ----
[00:46:26] diff of stderr:
[00:46:26] 
[00:46:26] - error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
[00:46:26] -   --> $DIR/edition-lint-nested-empty-paths.rs:27:5
[00:46:26] + error[E0658]: `crate` visibility modifier is experimental (see issue #45388)
[00:46:26] +   --> $DIR/edition-lint-nested-empty-paths.rs:18:1
[00:46:26] 3    |
[00:46:26] - LL | use foo::{bar::{baz::{}}};
[00:46:26] -    |     ^^^^^^^^^^^^^^^^^^^^^ help: use `crate`: `crate::foo::{bar::{baz::{}}}`
[00:46:26] + LL | crate mod foo {
[00:46:26] 6    |
[00:46:26] - note: lint level defined here
[00:46:26] -   --> $DIR/edition-lint-nested-empty-paths.rs:14:9
[00:46:26] -   --> $DIR/edition-lint-nested-empty-paths.rs:14:9
[00:46:26] +    = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable
[00:46:26] + 
[00:46:26] + error[E0658]: `crate` visibility modifier is experimental (see issue #45388)
[00:46:26] +   --> $DIR/edition-lint-nested-empty-paths.rs:19:5
[00:46:26] 9    |
[00:46:26] - LL | #![deny(absolute_paths_not_starting_with_crate)]
[00:46:26] -    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
[00:46:26] -    = note: for more information, see issue TBD
[00:46:26] -    = note: for more information, see issue TBD
[00:46:26] + LL |     crate mod bar {
[00:46:26] +    |
[00:46:26] +    |
[00:46:26] +    = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable
[00:46:26] 14 
[00:46:26] - error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
[00:46:26] -   --> $DIR/edition-lint-nested-empty-paths.rs:31:5
[00:46:26] + error[E0658]: `crate` visibility modifier is experimental (see issue #45388)
[00:46:26] +   --> $DIR/edition-lint-nested-empty-paths.rs:20:9
[00:46:26] 17    |
[00:46:26] - LL | use foo::{bar::{XX, baz::{}}};
[00:46:26] -    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `crate`: `crate::foo::{bar::{XX, baz::{}}}`
[00:46:26] + LL |         crate mod baz { }
[00:46:26] 20    |
[00:46:26] -    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
[00:46:26] -    = note: for more information, see issue TBD
[00:46:26] -    = note: for more information, see issue TBD
[00:46:26] +    = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable
[00:46:26] 23 
[00:46:26] - error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
[00:46:26] -   --> $DIR/edition-lint-nested-empty-paths.rs:35:5
[00:46:26] + error[E0658]: `crate` visibility modifier is experimental (see issue #45388)
[00:46:26] +   --> $DIR/edition-lint-nested-empty-paths.rs:21:9
[00:46:26] 26    |
[00:46:26] - LL | use foo::{bar::{baz::{}, baz1::{}}};
[00:46:26] -    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `crate`: `crate::foo::{bar::{baz::{}, baz1::{}}}`
[00:46:26] + LL |         crate mod baz1 { }
[00:46:26] 29    |
[00:46:26] -    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
[00:46:26] -    = note: for more information, see issue TBD
[00:46:26] -    = note: for more information, see issue TBD
[00:46:26] +    = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable
[00:46:26] - error: aborting due to 3 previous errors
[00:46:26] - error: aborting due to 3 previous errors
[00:46:26] + error[E0658]: `crate` visibility modifier is experimental (see issue #45388)
[00:46:26] +   --> $DIR/edition-lint-nested-empty-paths.rs:23:9
[00:46:26] +    |
[00:46:26] + LL |         crate struct XX;
[00:46:26] +    |
[00:46:26] +    |
[00:46:26] +    = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable
[00:46:26] + error: aborting due to 5 previous errors
[00:46:26] + 
[00:46:26] + For more information about this error, try `rustc --explain E0658`.
[00:46:26] 35 
---
[00:46:26] 
[00:46:26] 24     }
[00:46:26] 25 }
[00:46:26] 26 
[00:46:26] - use crate::foo::{bar::{baz::{}}};
[00:46:26] + use foo::{bar::{baz::{}}};
[00:46:26] 28 //~^ ERROR absolute paths must start with
[00:46:26] 29 //~| WARN this was previously accepted
[00:46:26] 
[00:46:26] 
[00:46:26] - use crate::foo::{bar::{XX, baz::{}}};
[00:46:26] + use foo::{bar::{XX, baz::{}}};
[00:46:26] 32 //~^ ERROR absolute paths must start with
[00:46:26] 33 //~| WARN this was previously accepted
[00:46:26] 
[00:46:26] 
[00:46:26] - use crate::foo::{bar::{baz::{}, baz1::{}}};
[00:46:26] + use foo::{bar::{baz::{}, baz1::{}}};
[00:46:26] 36 //~^ ERROR absolute paths must start with
[00:46:26] 37 //~| WARN this was previously accepted
[00:46:26] 
[00:46:26] 
[00:46:26] The actual fixed differed from the expected fixed.
[00:46:26] The actual fixed differed from the expected fixed.
[00:46:26] Actual fixed saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/edition-lint-nested-empty-paths/edition-lint-nested-empty-paths.fixed
[00:46:26] To update references, rerun the tests and pass the `--bless` flag
[00:46:26] To only update this specific test, also pass `--test-args rust-2018/edition-lint-nested-empty-paths.rs`
[00:46:26] error: 2 errors occurred comparing output.
[00:46:26] status: exit code: 1
[00:46:26] status: exit code: 1
[00:46:26] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rust-2018/edition-lint-nested-empty-paths.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/edition-lint-nested-empty-paths/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/edition-lint-nested-empty-paths/auxiliary" "-A" "unused"
[00:46:26] ------------------------------------------
[00:46:26] 
[00:46:26] ------------------------------------------
[00:46:26] stderr:
[00:46:26] stderr:
[00:46:26] ------------------------------------------
[00:46:26] {"message":"`crate` visibility modifier is experimental (see issue #45388)","code":{"code":"E0658","explanation":"\nAn unstable feature was used.\n\nErroneous code example:\n\n```compile_fail,E658\n#[repr(u128)] // error: use of unstable library feature 'repr128'\nenum Foo {\n    Bar(u64),\n}\n```\n\nIf you're using a stable or a beta version of rustc, you won't be able to use\nany unstable features. In order to do so, please switch to a nightly version of\nrustc (by using rustup).\n\nIf you're using a nightly version of rustc, just add the corresponding feature\nto be able to use it:\n\n```\n#![feature(repr128)]\n\n#[repr(u128)] // ok!\nenum Foo {\n    Bar(u64),\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/edition-lint-nested-empty-paths.rs","byte_start":611,"byte_end":616,"line_start":18,"line_end":18,"column_start":1,"column_end":6,"is_primary":true,"text":[{"text":"crate mod foo {","highlight_start":1,"highlight_end":6}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"add #![feature(crate_visibility_modifier)] to the crate attributes to enable","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0658]: `crate` visibility modifier is experimental (see issue #45388)\n  --> /checkout/src/test/ui/rust-2018/edition-lint-nested-empty-paths.rs:18:1\n   |\nLL | crate mod foo {\n   | ^^^^^\n   |\n   = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable\n\n"}
[00:46:26] {"message":"`crate` visibility modifier is experimental (see issue #45388)","code":{"code":"E0658","explanation":"\nAn unstable feature was used.\n\nErroneous code example:\n\n```compile_fail,E658\n#[repr(u128)] // error: use of unstable library feature 'repr128'\nenum Foo {\n    Bar(u64),\n}\n```\n\nIf you're using a stable or a beta version of rustc, you won't be able to use\nany unstable features. In order to do so, please switch to a nightly version of\nrustc (by using rustup).\n\nIf you're using a nightly version of rustc, just add the corresponding feature\nto be able to use it:\n\n```\n#![feature(repr128)]\n\n#[repr(u128)] // ok!\nenum Foo {\n    Bar(u64),\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/edition-lint-nested-empty-paths.rs","byte_start":631,"byte_end":636,"line_start":19,"line_end":19,"column_start":5,"column_end":10,"is_primary":true,"text":[{"text":"    crate mod bar {","highlight_start":5,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"add #![feature(crate_visibility_modifier)] to the crate attributes to enable","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0658]: `crate` visibility modifier is experimental (see issue #45388)\n  --> /checkout/src/test/ui/rust-2018/edition-lint-nested-empty-paths.rs:19:5\n   |\nLL |     crate mod bar {\n   |     ^^^^^\n   |\n   = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable\n\n"}
[00:46:26] {"message":"`crate` visibility modifier is experimental (see issue #45388)","code":{"code":"E0658","explanation":"\nAn unstable feature was used.\n\nErroneous code example:\n\n```compile_fail,E658\n#[repr(u128)] // error: use of unstable library feature 'repr128'\nenum Foo {\n    Bar(u64),\n}\n```\n\nIf you're using a stable or a beta version of rustc, you won't be able to use\nany unstable features. In order to do so, please switch to a nightly version of\nrustc (by using rustup).\n\nIf you're using a nightly version of rustc, just add the corresponding feature\nto be able to use it:\n\n```\n#![feature(repr128)]\n\n#[repr(u128)] // ok!\nenum Foo {\n    Bar(u64),\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/edition-lint-nested-empty-paths.rs","byte_start":655,"byte_end":660,"line_start":20,"line_end":20,"column_start":9,"column_end":14,"is_primary":true,"text":[{"text":"        crate mod baz { }","highlight_start":9,"highlight_end":14}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"add #![feature(crate_visibility_modifier)] to the crate attributes to enable","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0658]: `crate` visibility modifier is experimental (see issue #45388)\n  --> /checkout/src/test/ui/rust-2018/edition-lint-nested-empty-paths.rs:20:9\n   |\nLL |         crate mod baz { }\n   |         ^^^^^\n   |\n   = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable\n\n"}
[00:46:26] {"message":"`crate` visibility modifier is experimental (see issue #45388)","code":{"code":"E0658","explanation":"\nAn unstable feature was used.\n\nErroneous code example:\n\n```compile_fail,E658\n#[repr(u128)] // error: use of unstable library feature 'repr128'\nenum Foo {\n    Bar(u64),\n}\n```\n\nIf you're using a stable or a beta version of rustc, you won't be able to use\nany unstable features. In order to do so, please switch to a nightly version of\nrustc (by using rustup).\n\nIf you're using a nightly version of rustc, just add the corresponding feature\nto be able to use it:\n\n```\n#![feature(repr128)]\n\n#[repr(u128)] // ok!\nenum Foo {\n    Bar(u64),\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/edition-lint-nested-empty-paths.rs","byte_start":681,"byte_end":686,"line_start":21,"line_end":21,"column_start":9,"column_end":14,"is_primary":true,"text":[{"text":"        crate mod baz1 { }","highlight_start":9,"highlight_end":14}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"add #![feature(crate_visibility_modifier)] to the crate attributes to enable","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0658]: `crate` visibility modifier is experimental (see issue #45388)\n  --> /checkout/src/test/ui/rust-2018/edition-lint-nested-empty-paths.rs:21:9\n   |\nLL |         crate mod baz1 { }\n   |         ^^^^^\n   |\n   = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable\n\n"}
[00:46:26] {"message":"`crate` visibility modifier is experimental (see issue #45388)","code":{"code":"E0658","explanation":"\nAn unstable feature was used.\n\nErroneous code example:\n\n```compile_fail,E658\n#[repr(u128)] // error: use of unstable library feature 'repr128'\nenum Foo {\n    Bar(u64),\n}\n```\n\nIf you're using a stable or a beta version of rustc, you won't be able to use\nany unstable features. In order to do so, please switch to a nightly version of\nrustc (by using rustup).\n\nIf you're using a nightly version of rustc, just add the corresponding feature\nto be able to use it:\n\n```\n#![feature(repr128)]\n\n#[repr(u128)] // ok!\nenum Foo {\n    Bar(u64),\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/edition-lint-nested-empty-paths.rs","byte_start":709,"byte_end":714,"line_start":23,"line_end":23,"column_start":9,"column_end":14,"is_primary":true,"text":[{"text":"        crate struct XX;","highlight_start":9,"highlight_end":14}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"add #![feature(crate_visibility_modifier)] to the crate attributes to enable","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0658]: `crate` visibility modifier is experimental (see issue #45388)\n  --> /checkout/src/test/ui/rust-2018/edition-lint-nested-empty-paths.rs:23:9\n   |\nLL |         crate struct XX;\n   |         ^^^^^\n   |\n   = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable\n\n"}
[00:46:26] {"message":"aborting due to 5 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 5 previous e^^^^^^^^^^^
[00:46:26] -    = note: for more information, see issue TBD
[00:46:26] -    = note: for more information, see issue TBD
[00:46:26] + LL |     crate fn b() {}
[00:46:26] +    |
[00:46:26] +    |
[00:46:26] +    = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable
[00:46:26] 14 
[00:46:26] - error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
[00:46:26] -   --> $DIR/edition-lint-nested-paths.rs:31:13
[00:46:26] + error[E0658]: `crate` visibility modifier is experimental (see issue #45388)
[00:46:26] +   --> $DIR/edition-lint-nested-paths.rs:23:5
[00:46:26] 17    |
[00:46:26] - LL |         use foo::{self as x, c};
[00:46:26] -    |             ^^^^^^^^^^^^^^^^^^^ help: use `crate`: `crate::foo::{self as x, c}`
[00:46:26] + LL |     crate fn c() {}
[00:46:26] 20    |
[00:46:26] -    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
[00:46:26] -    = note: for more information, see issue TBD
[00:46:26] -    = note: for more information, see issue TBD
[00:46:26] +    = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable
[00:46:26] - error: aborting due to 2 previous errors
[00:46:26] + error: aborting due to 3 previous errors
[00:46:26] 25 
[00:46:26] + For more information about this error, try `rustc --explain E0658`.
[00:46:26] + For more information about this error, try `rustc --explain E0658`.
[00:46:26] 26 
[00:46:26] 
[00:46:26] 
[00:46:26] The actual stderr differed from the expected stderr.
[00:46:26] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/edition-lint-nested-paths/edition-lint-nested-paths.stderr
[00:46:26] diff of fixed:
[00:46:26] 
[00:46:26] 13 #![feature(rust_2018_preview)]
[00:46:26] 14 #![deny(absolute_paths_not_starting_with_crate)]
[00:46:26] 15 
[00:46:26] - use crate::foo::{a, b};
[00:46:26] + use foo::{a, b};
[00:46:26] 17 //~^ ERROR absolute paths must start with
[00:46:26] 18 //~| this was previously accepted
[00:46:26] 
[00:46:26] 28     b();
[00:46:26] 29 
[00:46:26] 30     {
[00:46:26] 30     {
[00:46:26] -         use crate::foo::{self as x, c};
[00:46:26] +         use foo::{self as x, c};
[00:46:26] 32         //~^ ERROR absolute paths must start with
[00:46:26] 33         //~| this was previously accepted
[00:46:26] 34         x::a();
[00:46:26] 
[00:46:26] The actual fixed differed from the expected fixed.
[00:46:26] The actual fixed differed from the expected fixed.
[00:46:26] Actual fixed saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/edition-lint-nested-paths/edition-lint-nested-paths.fixed
[00:46:26] To update references, rerun the tests and pass the `--bless` flag
[00:46:26] To only update this specific test, also pass `--test-args rust-2018/edition-lint-nested-paths.rs`
[00:46:26] error: 2 errors occurred comparing output.
[00:46:26] status: exit code: 1
[00:46:26] status: exit code: 1
[00:46:26] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rust-2018/edition-lint-nested-paths.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/edition-lint-nested-paths/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/edition-lint-nested-paths/auxiliary" "-A" "unused"
[00:46:26] ------------------------------------------
[00:46:26] 
[00:46:26] ------------------------------------------
[00:46:26] stderr:
[00:46:26] stderr:
[00:46:26] ------------------------------------------
[00:46:26] {"message":"`crate` visibility modifier is experimental (see issue #45388)","code":{"code":"E0658","explanation":"\nAn unstable feature was used.\n\nErroneous code example:\n\n```compile_fail,E658\n#[repr(u128)] // error: use of unstable library feature 'repr128'\nenum Foo {\n    Bar(u64),\n}\n```\n\nIf you're using a stable or a beta version of rustc, you won't be able to use\nany unstable features. In order to do so, please switch to a nightly version of\nrustc (by using rustup).\n\nIf you're using a nightly version of rustc, just add the corresponding feature\nto be able to use it:\n\n```\n#![feature(repr128)]\n\n#[repr(u128)] // ok!\nenum Foo {\n    Bar(u64),\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/edition-lint-nested-paths.rs","byte_start":672,"byte_end":677,"line_start":21,"line_end":21,"column_start":5,"column_end":10,"is_primary":true,"text":[{"text":"    crate fn a() {}","highlight_start":5,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"add #![feature(crate_visibility_modifier)] to the crate attributes to enable","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0658]: `crate` visibility modifier is experimental (see issue #45388)\n  --> /checkout/src/test/ui/rust-2018/edition-lint-nested-paths.rs:21:5\n   |\nLL |     crate fn a() {}\n   |     ^^^^^\n   |\n   = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable\n\n"}
[00:46:26] {"message":"`crate` visibility modifier is experimental (see issue #45388)","code":{"code":"E0658","explanation":"\nAn unstable feature was used.\n\nErroneous code example:\n\n```compile_fail,E658\n#[repr(u128)] // error: use of unstable library feature 'repr128'\nenum Foo {\n    Bar(u64),\n}\n```\n\nIf you're using a stable or a beta version of rustc, you won't be able to use\nany unstable features. In order to do so, please switch to a nightly version of\nrustc (by using rustup).\n\nIf you're using a nightly version of rustc, just add the corresponding feature\nto be able to use it:\n\n```\n#![feature(repr128)]\n\n#[repr(u128)] // ok!\nenum Foo {\n    Bar(u64),\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/edition-lint-nested-paths.rs","byte_start":692,"byte_end":697,"line_start":22,"line_end":22,"column_start":5,"column_end":10,"is_primary":true,"text":[{"text":"    crate fn b() {}","highlight_start":5,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"add #![feature(crate_visibility_modifier)] to the crate attributes to enable","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0658]: `crate` visibility modifier is experimental (see issue #45388)\n  --> /checkout/src/test/ui/rust-2018/edition-lint-nested-paths.rs:22:5\n   |\nLL |     crate fn b() {}\n   |     ^^^^^\n   |\n   = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable\n\n"}
[00:46:26] {"message":"`crate` visibility modifier is experimental (see issue #45388)","code":{"code":"E0658","explanation":"\nAn unstable feature was used.\n\nErroneous code example:\n\n```compile_fail,E658\n#[repr(u128)] // error: use of unstable library feature 'repr128'\nenum Foo {\n    Bar(u64),\n}\n```\n\nIf you're using a stable or a beta version of rustc, you won't be able to use\nany unstable features. In order to do so, please switch to a nightly version of\nrustc (by using rustup).\n\nIf you're using a nightly version of rustc, just add the corresponding feature\nto be able to use it:\n\n```\n#![feature(repr128)]\n\n#[repr(u128)] // ok!\nenum Foo {\n    Bar(u64),\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/edition-lint-nested-paths.rs","byte_start":712,"byte_end":717,"line_start":23,"line_end":23,"column_start":5,"column_end":10,"is_primary":true,"text":[{"text":"    crate fn c() {}","highlight_start":5,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"add #![feature(crate_visibility_modifier)] to the crate attributes to enable","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0658]: `crate` visibility modifier is experimental (see issue #45388)\n  --> /checkout/src/test/ui/rust-2018/edition-lint-nested-paths.rs:23:5\n   |\nLL |     crate fn c() {}\n   |     ^^^^^\n   |\n   = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable\n\n"}
[00:46:26] {"message":"aborting due to 3 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 3 previous errors\n\n"}
[00:46:26] {"message":"For more information about this error, try `rustc --explain E0658`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0658`.\n"}
[00:46:26] ------------------------------------------
[00:46:26] 
[00:46:26] thread '[ui] ui/rust-2018/edition-lint-nested-paths.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3196:9
[00:46:26] 
---
[00:46:26] 
[00:46:26] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:497:22
[00:46:26] 
[00:46:26] 
[00:46:26] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:46:26] 
[00:46:26] 
[00:46:26] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:46:26] Build completed unsuccessfully in 0:03:01
[00:46:26] Build completed unsuccessfully in 0:03:01
[00:46:26] Makefile:58: recipe for target 'check' failed
[00:46:26] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:32051bd8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0029730e:start=1536256129602585411,finish=1536256129608858098,duration=6272687
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1773a854
$ ln -s . checkout && f

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Mark-Simulacrum · 2018-09-07T00:56:01Z

Okay, I believe this should work now, but still running tests locally.

An interesting thing I noticed is that rust_2018_preview is currently required to get some edition lints to fire, because otherwise the code won't report the warnings/errors. Is this expected? I'm not sure, but it feels like perhaps no. @alexcrichton, do you perhaps know?

If this is expected we might want to alias some other feature to it since once we ship I'd rather not have users writing "preview". cc @Centril, @aturon

Otherwise I believe this is ready for review

r? @alexcrichton

rust-highfive · 2018-09-07T01:55:00Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:50:32] ....................................................................................................
[00:50:36] ....................................................................................................
[00:50:39] ........................................i...........................................................
[00:50:41] ....................................................................................................
[00:50:44] .........................................................................................iiiiiiiii..
[00:50:50] ...........ii.......................................................................................
[00:50:54] ....................................................................................................
[00:50:57] ......................................................................i.............................
[00:51:00] ....................................................................................................
---
travis_time:start:test_ui-fulldeps
Check compiletest suite=ui-fulldeps mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:58:44] 
[00:58:44] running 30 tests
/unnecessary-extern-crate.rs:38:1\n   |\nLL | crate extern crate libc as b;\n   | ^^^^^\n   |\n   = help: add #![feature(crate_visibility_modifier)] to the crate attributes to enable\n\n"}
[00:59:06] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[00:59:06] {"message":"For more information about this error, try `rustc --explain E0658`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0658`.\n"}
[00:59:06] ------------------------------------------
[00:59:06] 
[00:59:06] thread '[ui] ui-fulldeps/unnecessary-extern-crate.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3196:9
[00:59:06] note: Run with `RUST_BACKTRACE=1` for a backtrace.
---
[00:59:06] test result: FAILED. 29 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[00:59:06] 
[00:59:06] 
[00:59:06] 
[00:59:06] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-

The command "date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
" exited with 0.
travis_fold:start:after_failure.1

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton · 2018-09-07T02:09:45Z

This looks good to me! r=me with green travis

And yeah it's expected that transition lints don't fire unless the unstable feature is enabled. Once everything stabilizes though they'll fire by default.

Mark-Simulacrum · 2018-09-07T03:43:16Z

Going to r+ this since I've run a good portion of tests locally...

@bors r=alexcrichton

bors · 2018-09-07T03:43:17Z

📌 Commit 8c3ac3c has been approved by alexcrichton

Mark-Simulacrum · 2018-09-07T16:35:50Z

@bors p=1

@eddyb

…r=alexcrichton Stabilize 2018 edition r? @eddyb cc @Centril @aturon

bors · 2018-09-07T22:19:04Z

⌛ Testing commit 8c3ac3c with merge affbf667000602372b2861aff5be6f8f0957fafa...

matthiaskrgr · 2018-09-07T22:44:09Z

This is probably going to fail just as #54036 due to crate vis modifier used as part 2018 without feature gate in clippy.

Mark-Simulacrum · 2018-09-07T23:02:13Z

Yes, that seems likely. I'll try to coordinate a fix. @bors r-

Mark-Simulacrum · 2018-09-07T23:02:28Z

@bors retry

bors · 2018-09-07T23:02:39Z

⌛ Trying commit 8c3ac3c with merge e5eae34...

@eddyb

Stabilize 2018 edition r? @eddyb cc @Centril @aturon

…o longer part of 2018 edition. Fixes build with rust-lang/rust#53999

matthiaskrgr · 2018-09-07T23:35:26Z

rust-lang/rust-clippy#3150 will make clippy compatible with this PR.

matthiaskrgr · 2018-09-07T23:39:45Z

Ah, then we'll also have to update clippy_lints used in RLS and push a RLS update to rustc ....

mati865 · 2018-09-08T01:06:47Z

@matthiaskrgr clippy_lints version is patched in this repository. So when you update Clippy submodule, RLS will be build with that updated version.

matthiaskrgr · 2018-09-08T01:09:02Z

Ah, excellent, I didn't notice that :D

bors · 2018-09-08T01:14:17Z

☀️ Test successful - status-travis
State: approved= try=True

matthiaskrgr · 2018-09-08T12:30:42Z

You can see in the log that clippy build failed, yet bors didn't see this as a reason to mark the build as failed https://api.travis-ci.org/v3/job/425956240/log.txt

Mark-Simulacrum · 2018-09-08T12:34:25Z

I'll update this PR to include a clippy bump sometime today.

matthiaskrgr · 2018-09-08T12:38:20Z

In case you want it, I already have a rebased version with this PR + clippy bump in the pipeline but I didn't push yet because I wanted to wait until local testbuild is done.

Mark-Simulacrum · 2018-09-08T12:41:21Z

Yes, that would be great, thanks!

matthiaskrgr · 2018-09-08T13:18:04Z

Ok, it turned out that rls suffers from the same problem but we never got that far because clippy_lint dependency was already broken.
The PR fixing RLS is here: rust-lang/rls#1050

I have to go AFK for most of the rest of the day in an hour or two, I allowed editing by maintainers on #54057 so once the fix is merged into rls, you can hopefully add that to the PR and it should be good to go... 😅

Xanewok · 2018-09-08T19:32:21Z

@Mark-Simulacrum @matthiaskrgr done, latest commit with the mentioned fix is rust-lang/rls@5b5cd9d

cc #54057

@Mark-Simulacrum

…-clippy, r=alexcrichton Stabilize edition 2018; also updates Clippy and RLS Supersedes rust-lang#53999 Clippy build was failing there because crate_visibility_modifier feature was taken out of edition 2018 and clippy used it. The clippy update enables the corresponding feature explicitly. r? @Mark-Simulacrum

@Mark-Simulacrum

…Mark-Simulacrum Stabilize edition 2018; also updates Clippy, RLS and Cargo Supersedes #53999 , #53935 Clippy build was failing there because crate_visibility_modifier feature was taken out of edition 2018 and clippy used it. The clippy update enables the corresponding feature explicitly. r? @Mark-Simulacrum

rust-highfive assigned eddyb Sep 6, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2018

Centril reviewed Sep 6, 2018

View reviewed changes

Mark-Simulacrum force-pushed the stabilize-edition branch from cdb1847 to b30ad60 Compare September 7, 2018 00:52

Stabilize the 2018 edition

73dd19f

Mark-Simulacrum force-pushed the stabilize-edition branch from b30ad60 to 6935a19 Compare September 7, 2018 00:53

rust-highfive assigned alexcrichton and unassigned eddyb Sep 7, 2018

Remove crate_visibility_modifier from 2018 edition

8c3ac3c

Mark-Simulacrum force-pushed the stabilize-edition branch from 6935a19 to 8c3ac3c Compare September 7, 2018 03:02

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2018

kennytm added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 7, 2018

kennytm mentioned this pull request Sep 7, 2018

Rollup of 9 pull requests #54036

Closed

kennytm added a commit to kennytm/rust that referenced this pull request Sep 7, 2018

Rollup merge of rust-lang#53999 - Mark-Simulacrum:stabilize-edition, …

1e4aa65

…r=alexcrichton Stabilize 2018 edition r? @eddyb cc @Centril @aturon

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 7, 2018

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 7, 2018

bors added a commit that referenced this pull request Sep 7, 2018

Auto merge of #53999 - Mark-Simulacrum:stabilize-edition, r=<try>

e5eae34

Stabilize 2018 edition r? @eddyb cc @Centril @aturon

matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Sep 7, 2018

clippy_lints: enable crate_visibility_modifier since it is used but n…

f6935be

…o longer part of 2018 edition. Fixes build with rust-lang/rust#53999

matthiaskrgr mentioned this pull request Sep 7, 2018

clippy_lints: enable crate_visibility_modifier since it is used but no longer part of 2018 edition. rust-lang/rust-clippy#3150

Merged

matthiaskrgr mentioned this pull request Sep 8, 2018

Stabilize edition 2018; also updates Clippy, RLS and Cargo #54057

Merged

Mark-Simulacrum closed this Sep 8, 2018

Mark-Simulacrum deleted the stabilize-edition branch June 8, 2019 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize 2018 edition #53999

Stabilize 2018 edition #53999

Mark-Simulacrum commented Sep 6, 2018

Centril Sep 6, 2018

rust-highfive commented Sep 6, 2018

Mark-Simulacrum commented Sep 7, 2018

rust-highfive commented Sep 7, 2018

alexcrichton commented Sep 7, 2018

Mark-Simulacrum commented Sep 7, 2018

bors commented Sep 7, 2018

Mark-Simulacrum commented Sep 7, 2018

bors commented Sep 7, 2018

matthiaskrgr commented Sep 7, 2018

Mark-Simulacrum commented Sep 7, 2018

Mark-Simulacrum commented Sep 7, 2018

bors commented Sep 7, 2018

matthiaskrgr commented Sep 7, 2018

matthiaskrgr commented Sep 7, 2018

mati865 commented Sep 8, 2018 •

edited

Loading

matthiaskrgr commented Sep 8, 2018

bors commented Sep 8, 2018

matthiaskrgr commented Sep 8, 2018

Mark-Simulacrum commented Sep 8, 2018

matthiaskrgr commented Sep 8, 2018

Mark-Simulacrum commented Sep 8, 2018

matthiaskrgr commented Sep 8, 2018

Xanewok commented Sep 8, 2018 •

edited

Loading

Stabilize 2018 edition #53999

Stabilize 2018 edition #53999

Conversation

Mark-Simulacrum commented Sep 6, 2018

Centril Sep 6, 2018

Choose a reason for hiding this comment

rust-highfive commented Sep 6, 2018

Mark-Simulacrum commented Sep 7, 2018

rust-highfive commented Sep 7, 2018

alexcrichton commented Sep 7, 2018

Mark-Simulacrum commented Sep 7, 2018

bors commented Sep 7, 2018

Mark-Simulacrum commented Sep 7, 2018

bors commented Sep 7, 2018

matthiaskrgr commented Sep 7, 2018

Mark-Simulacrum commented Sep 7, 2018

Mark-Simulacrum commented Sep 7, 2018

bors commented Sep 7, 2018

matthiaskrgr commented Sep 7, 2018

matthiaskrgr commented Sep 7, 2018

mati865 commented Sep 8, 2018 • edited Loading

matthiaskrgr commented Sep 8, 2018

bors commented Sep 8, 2018

matthiaskrgr commented Sep 8, 2018

Mark-Simulacrum commented Sep 8, 2018

matthiaskrgr commented Sep 8, 2018

Mark-Simulacrum commented Sep 8, 2018

matthiaskrgr commented Sep 8, 2018

Xanewok commented Sep 8, 2018 • edited Loading

mati865 commented Sep 8, 2018 •

edited

Loading

Xanewok commented Sep 8, 2018 •

edited

Loading