Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deployment and documentation #5171

Merged
merged 4 commits into from
Feb 14, 2020
Merged

Improve deployment and documentation #5171

merged 4 commits into from
Feb 14, 2020

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Feb 13, 2020

This should be merged shortly after #5172

This extracts the python code that generated the versions.json file and now sorts the versions. in addition to that it improves the order on the website, respecting the new rust-* directories.

The new appearance of the documentation site can be previewed here: https://flip1995.github.io/rust-clippy/

changelog: Add documentation for Clippy stable releases at https://rust-lang.github.io/rust-clippy/

This changes the formatting a bit of json.dump(..)
@flip1995 flip1995 changed the title [WIP] Improve deployment and documentation Improve deployment and documentation Feb 13, 2020
@flip1995 flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 13, 2020
@flip1995
Copy link
Member Author

Should we rename the current dir to current-stable or just stable?

@JohnTitor
Copy link
Member

+1 to rename current to stable.

@flip1995 flip1995 closed this Feb 14, 2020
@flip1995 flip1995 reopened this Feb 14, 2020
@flip1995
Copy link
Member Author

flip1995 commented Feb 14, 2020

I deleted the Travis caches, let's see if that solved the weird rustfmt bug

@flip1995
Copy link
Member Author

It did.

@bors p=1000 treeclosed=1000

@flip1995
Copy link
Member Author

@bors r=Manishearth

@bors
Copy link
Collaborator

bors commented Feb 14, 2020

📌 Commit 0f79182 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Feb 14, 2020

⌛ Testing commit 0f79182 with merge bdd4046...

bors added a commit that referenced this pull request Feb 14, 2020
Improve deployment and documentation

**This should be merged shortly after** #5172

This extracts the python code that generated the `versions.json` file and now sorts the versions. in addition to that it improves the order on the website, respecting the new `rust-*` directories.

The new appearance of the documentation site can be previewed here: https://flip1995.github.io/rust-clippy/

changelog: Add documentation for Clippy stable releases at https://rust-lang.github.io/rust-clippy/
@bors
Copy link
Collaborator

bors commented Feb 14, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing bdd4046 to master...

@bors bors merged commit 0f79182 into rust-lang:master Feb 14, 2020
@flip1995 flip1995 deleted the deploy branch February 14, 2020 14:00
bors added a commit that referenced this pull request Feb 19, 2020
…logiq,flip1995

I like to move it, move it

GHA now runs in the background for 6 days (#5088)

Since then ~~15~~ 19 PRs were successfully merged and Travis+Appveyor agreed on the status in every case. ([GitHub PR search query](https://github.com/rust-lang/rust-clippy/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+merged%3A%3E%3D2020-02-12T15%3A42%3A00+sort%3Aupdated-desc+NOT+%5Bgh-pages%5D+in%3Atitle))

Some PRs were:
- #5163
- #5170
- #5168
- #5173
- #5171
- #5156
- #4809
- #5177
- #5182
- #5183
- #5184
- #5185
- #5186
- #5181
- #5189

Bug with GHA:
- When a rustc PR gets merged between the `integration_build` and the `integration` job, the `integration` job will fail. This happened once in #5162, but not in the past 6 days. Even if it would happen every 4th PR we would save time, since splitting up the integration build and tests saves 5-7 minutes per run and a complete run takes 15-17 minutes
- Sometimes the MacOS build takes up to an hour to download the master toolchain. Until now, this happend 2 or 3 times and can be resolved by a `@bors r3try`+canceling the previous run (restarting single jobs is not supported yet)

## Before merging this, rust-lang/rust-central-station#578 has to get merged

This PR is for starting the discussion and to get consensus (@rust-lang/clippy) on a final move to GHA. If we're ready, I'll contact Pietro, to finalize the move.

changelog: Clippy completely runs on GHA now 🎉

---

BTW: The deployment already runs on GHA, instead of Travis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants