Add lint for .. use in fully binded struct #5258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
added
the
S-waiting-on-review
flip1995
requested changes
Mar 3, 2020
flip1995
added
S-waiting-on-author
ThibsG
force-pushed
the
UselessBindingInStruct638
branch
from
0184752
to
fb85dba
Compare
flip1995
reviewed
Mar 3, 2020
ThibsG
force-pushed
the
UselessBindingInStruct638
branch
from
fb85dba
to
041dd54
Compare
flip1995
approved these changes
Mar 3, 2020
flip1995
reviewed
Mar 3, 2020
ThibsG
force-pushed
the
UselessBindingInStruct638
branch
from
041dd54
to
6526b2b
Compare
|
@bors r+ Thanks! |
|
📌 Commit 6526b2b has been approved by |
bors
added a commit
that referenced
this pull request
Mar 3, 2020
Add lint for .. use in fully binded struct This PR adds the lint `match-wild-in-fully-binded-struct` to prevent the use of the `..` pattern when all fields of the struct are already binded. Fixes: #638 changelog: Add [`rest_pat_in_fully_bound_structs`] lint to warn against the use of `..` in fully binded struct
|
💔 Test failed - checks-action_test |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Mar 3, 2020
Add lint for .. use in fully binded struct This PR adds the lint `match-wild-in-fully-binded-struct` to prevent the use of the `..` pattern when all fields of the struct are already binded. Fixes: #638 changelog: Add [`rest_pat_in_fully_bound_structs`] lint to warn against the use of `..` in fully binded struct
|
💔 Test failed - checks-action_test |
flip1995
requested changes
Mar 3, 2020
ThibsG
force-pushed
the
UselessBindingInStruct638
branch
from
6526b2b
to
b4eac00
Compare
flip1995
approved these changes
Mar 3, 2020
|
@bors r+ |
|
📌 Commit b4eac00 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 3, 2020
Add lint for .. use in fully binded struct This PR adds the lint `match-wild-in-fully-binded-struct` to prevent the use of the `..` pattern when all fields of the struct are already binded. Fixes: #638 changelog: Add [`rest_pat_in_fully_bound_structs`] lint to warn against the use of `..` in fully binded struct
|
💔 Test failed - checks-action_test |
flip1995
reviewed
Mar 3, 2020
ThibsG
force-pushed
the
UselessBindingInStruct638
branch
from
b4eac00
to
2aa14c9
Compare
|
@bors r+ |
|
📌 Commit 2aa14c9 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 4, 2020
Add lint for .. use in fully binded struct This PR adds the lint `match-wild-in-fully-binded-struct` to prevent the use of the `..` pattern when all fields of the struct are already binded. Fixes: #638 changelog: Add [`rest_pat_in_fully_bound_structs`] lint to warn against the use of `..` in fully binded struct
|
💔 Test failed - checks-action_test |
|
@bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the lint
match-wild-in-fully-binded-structto prevent the use of the..pattern when all fields of the struct are already binded.Fixes: #638
changelog: Add [
rest_pat_in_fully_bound_structs] lint to warn against the use of..in fully binded struct