Decrease line lengths by one

[chris-morgan]

Although people speak of 80, 79 is actually the number they mean, because terminals will tend to need an extra, blank line if you write 80-character-wide lines.

These changes are in line with PEP 8’s recommendations:

Limit all lines to a maximum of 79 characters.

…

Some teams strongly prefer a longer line length. For code maintained exclusively or primarily by a team that can reach agreement on this issue, it is okay to increase the nominal line length from 80 to 100 characters (effectively increasing the maximum length to 99 characters), provided that comments and docstrings are still wrapped at 72 characters.

(We can deal with its docstrings 72 characters at another time; the wisdom of it is much more debatable.

[nathantypanski]

Isn't the general Rust convention "hard limit at 120 columns; soft limit at
80" - so suggesting 80 as the hard limit is perhaps too strict?
On Jul 3, 2014 9:46 PM, "Chris Morgan" notifications@github.com wrote:

Although people speak of 80, 79 is actually the number they mean, because
terminals will tend to need an extra, blank line if you write
80-character-wide lines.

These changes are in line with PEP 8’s recommendations:

Limit all lines to a maximum of 79 characters.

…

Some teams strongly prefer a longer line length. For code maintained
exclusively or primarily by a team that can reach agreement on this issue,
it is okay to increase the nominal line length from 80 to 100 characters
(effectively increasing the maximum length to 99 characters), provided that
comments and docstrings are still wrapped at 72 characters.

(We can deal with its docstrings 72 characters at another time; the wisdom

of it is much more debatable.

You can merge this Pull Request by running

git pull https://github.com/chris-morgan/rust-guidelines patch-1

Or view, comment on, or merge it at:

#12
Commit Summary

• Decrease line lengths by one

File Changes

• M style/whitespace.md
  https://github.com/aturon/rust-guidelines/pull/12/files#diff-0 (2)

Patch Links:

• https://github.com/aturon/rust-guidelines/pull/12.patch
• https://github.com/aturon/rust-guidelines/pull/12.diff

—
Reply to this email directly or view it on GitHub
#12.

[nathantypanski]

Er nvm - reading the commit details I see there's a hard limit at ~100,
soft limit at 80. I agree with this commit: 79 is an "80 column wrap" and
99 is a proper "100 col wrap".

[aturon]

Thanks @chris-morgan. As a heads up, discussion with the core team suggests that the soft limit/hard limit setup here is probably going away, in favor of something like a fixed 99 character limit.

If you change this to just state a 99 character limit, I'll merge it :-)