Rollup merge of #69430 - matthiaskrgr:noloop, r=varkor

librustc_typeck: remove loop that never actually loops
rust-lang · Feb 28, 2020 · 84f5bcc · 84f5bcc
2 parents 350491d + b6f0567
commit 84f5bcc
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/librustc_typeck/astconv.rs b/src/librustc_typeck/astconv.rs
@@ -2439,10 +2439,11 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {
                     break;
                 }
             }
-            for binding in segment.generic_args().bindings {
+
+            // Only emit the first error to avoid overloading the user with error messages.
+            if let [binding, ..] = segment.generic_args().bindings {
                 has_err = true;
                 Self::prohibit_assoc_ty_binding(self.tcx(), binding.span);
-                break;
             }
         }
         has_err