librustc_typeck: remove loop that never actually loops #69430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Feb 24, 2020
src/librustc_typeck/astconv.rs
Outdated
| @@ -2358,10 +2358,10 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o { | |||
| break; | |||
| } | |||
| } | |||
| for binding in segment.generic_args().bindings { | |||
|
|
|||
| if let Some(binding) = segment.generic_args().bindings.get(0) { | |||
There was a problem hiding this comment.
Suggested change
| if let Some(binding) = segment.generic_args().bindings.get(0) { | |
| if let [binding, ..] = segment.generic_args().bindings { |
Although cc @varkor re. whether this weird break was correct in the first place. I think this deserves a comment at any rate.
|
r? @varkor |
matthiaskrgr
force-pushed
the
noloop
branch
2 times, most recently
from
6520e6d to
51978f1
Compare
varkor
reviewed
Feb 27, 2020
varkor
reviewed
Feb 27, 2020
src/librustc_typeck/astconv.rs
Outdated
| @@ -2358,10 +2358,11 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o { | |||
| break; | |||
| } | |||
| } | |||
| for binding in segment.generic_args().bindings { | |||
|
|
|||
| // only emit the first error to avoid overloading the user with error msgs | |||
There was a problem hiding this comment.
Suggested change
| // only emit the first error to avoid overloading the user with error msgs | |
| // Only emit the first error to avoid overloading the user with error messages. |
We generally prefer full sentences for consistency.
r=me after fixing.
|
@bors r+ rollup |
|
📌 Commit b6f0567 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 27, 2020
librustc_typeck: remove loop that never actually loops
bors
added a commit
that referenced
this pull request
Feb 27, 2020
Rollup of 8 pull requests Successful merges: - #60826 (Implement new gdb/lldb pretty-printers) - #69255 (Add more context to E0599 errors) - #69379 (Fail on multiple declarations of `main`.) - #69430 (librustc_typeck: remove loop that never actually loops) - #69449 (Do not ping PR reviewers in toolstate breakage) - #69491 (rustc_span: Add `Symbol::to_ident_string` for use in diagnostic messages) - #69495 (don't take redundant references to operands) - #69496 (use find(x) instead of filter(x).next()) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Feb 28, 2020
Rollup of 9 pull requests Successful merges: - #69379 (Fail on multiple declarations of `main`.) - #69430 (librustc_typeck: remove loop that never actually loops) - #69449 (Do not ping PR reviewers in toolstate breakage) - #69491 (rustc_span: Add `Symbol::to_ident_string` for use in diagnostic messages) - #69495 (don't take redundant references to operands) - #69496 (use find(x) instead of filter(x).next()) - #69501 (note that find(f) is equivalent to filter(f).next() in the docs.) - #69527 (Ignore untracked paths when running `rustfmt` on repository.) - #69529 (don't use .into() to convert types into identical types.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.