Skip to content

Commit

Permalink
auto merge of #20794 : sfackler/rust/trailing-attrs, r=alexcrichton
Browse files Browse the repository at this point in the history
Closes #20711
  • Loading branch information
bors committed Jan 10, 2015
2 parents 391e010 + cbd962e commit d36dc15
Show file tree
Hide file tree
Showing 4 changed files with 49 additions and 5 deletions.
9 changes: 6 additions & 3 deletions src/libcore/str/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1616,22 +1616,25 @@ impl<'a> Iterator for Lines<'a> {
fn next(&mut self) -> Option<&'a str> { self.inner.next() }
#[inline]
fn size_hint(&self) -> (uint, Option<uint>) { self.inner.size_hint() }
}

#[stable]}
#[stable]
impl<'a> DoubleEndedIterator for Lines<'a> {
#[inline]
fn next_back(&mut self) -> Option<&'a str> { self.inner.next_back() }
}

#[stable]}
#[stable]
impl<'a> Iterator for LinesAny<'a> {
type Item = &'a str;

#[inline]
fn next(&mut self) -> Option<&'a str> { self.inner.next() }
#[inline]
fn size_hint(&self) -> (uint, Option<uint>) { self.inner.size_hint() }
}

#[stable]}
#[stable]
impl<'a> DoubleEndedIterator for LinesAny<'a> {
#[inline]
fn next_back(&mut self) -> Option<&'a str> { self.inner.next_back() }
Expand Down
8 changes: 6 additions & 2 deletions src/libsyntax/parse/parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4769,8 +4769,12 @@ impl<'a> Parser<'a> {
self.expect(&token::OpenDelim(token::Brace));
let (inner_attrs, mut method_attrs) =
self.parse_inner_attrs_and_next();
while !self.eat(&token::CloseDelim(token::Brace)) {
loop {
method_attrs.extend(self.parse_outer_attributes().into_iter());
if method_attrs.is_empty() && self.eat(&token::CloseDelim(token::Brace)) {
break;
}

let vis = self.parse_visibility();
if self.eat_keyword(keywords::Type) {
impl_items.push(TypeImplItem(P(self.parse_typedef(
Expand All @@ -4781,7 +4785,7 @@ impl<'a> Parser<'a> {
method_attrs,
vis)));
}
method_attrs = self.parse_outer_attributes();
method_attrs = vec![];
}
(impl_items, inner_attrs)
}
Expand Down
20 changes: 20 additions & 0 deletions src/test/compile-fail/issue-20711-2.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

struct Foo;

impl Foo {
fn foo() {}

#[stable]
} //~ ERROR expected `fn`, found `}`

fn main() {}

17 changes: 17 additions & 0 deletions src/test/compile-fail/issue-20711.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

struct Foo;

impl Foo {
#[stable]
} //~ ERROR expected `fn`, found `}`

fn main() {}

0 comments on commit d36dc15

Please sign in to comment.