Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing attributes are accepted in impl blocks #20711

Closed
sfackler opened this issue Jan 7, 2015 · 1 comment · Fixed by #20794
Closed

Trailing attributes are accepted in impl blocks #20711

sfackler opened this issue Jan 7, 2015 · 1 comment · Fixed by #20794
Labels
A-parser Area: The parsing of Rust source code to an AST.

Comments

@sfackler
Copy link
Member

sfackler commented Jan 7, 2015 

struct Foo;

impl Foo {
    #[stable]
}

fn main() {}
@sfackler sfackler added the A-parser Area: The parsing of Rust source code to an AST. label Jan 7, 2015
@sfackler
Copy link
Member Author

sfackler commented Jan 7, 2015

Nominating - not sure if we'd treat a fix for this after 1.0 as breaking back compat.

@sfackler sfackler mentioned this issue Jan 7, 2015
Merged
sfackler added a commit to sfackler/rust that referenced this issue Jan 9, 2015
@sfackler
Forbid trailing attributes in impl blocks
cbd962e 
Closes rust-lang#20711
@sfackler sfackler mentioned this issue Jan 9, 2015
Merged
bors added a commit that referenced this issue Jan 10, 2015
@bors
auto merge of #20794 : sfackler/rust/trailing-attrs, r=alexcrichton
d36dc15 
Closes #20711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parser Area: The parsing of Rust source code to an AST.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forbid trailing attributes in impl blocks sfackler/rust
1 participant
@sfackler