Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: change in overflow checking #103274

Open
Mark-Simulacrum opened this issue Oct 19, 2022 · 2 comments
Open

regression: change in overflow checking #103274

Mark-Simulacrum opened this issue Oct 19, 2022 · 2 comments
Labels
P-medium Medium priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
1.65.0

Comments

@Mark-Simulacrum
Copy link
Member

The regression in diesel-softdelete is separate and regressed in #100757

Looks like we changed the boundary here which seems like it causes needless breakage for users - not convinced we should do that.

Originally posted by @compiler-errors in #103243 (comment)
@Mark-Simulacrum Mark-Simulacrum added this to the 1.65.0 milestone Oct 19, 2022
@Mark-Simulacrum Mark-Simulacrum added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Oct 19, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 19, 2022
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. P-medium Medium priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Oct 19, 2022
@compiler-errors compiler-errors mentioned this issue Nov 12, 2022
Closed
@compiler-errors
Copy link
Member

@ouz-a I think we might need to revert #100757 because of this issue and #104322 (and #104606 mentioning this too) -- do you want to do that, or should I?

@ouz-a
Copy link
Contributor

ouz-a commented Nov 19, 2022

@compiler-errors this is going to introduce small(compared to issues it raised) regressions, but I can revert it.

@ouz-a ouz-a mentioned this issue Nov 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 24, 2022
@bors
Auto merge of rust-lang#104610 - ouz-a:revert-overflow, r=compiler-er…
fd815a5 
…rors

Reverts check done by rust-lang#100757

As my `fix` caused more issues than it resolved it's better to revert it.
( rust-lang#103274 rust-lang#104322 rust-lang#104606)

r? `@compiler-errors`

Reopens rust-lang#95134
@Mark-Simulacrum Mark-Simulacrum added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. and removed regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Dec 9, 2022
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#104610 - ouz-a:revert-overflow, r=compiler-er…
7edf87a 
…rors

Reverts check done by rust-lang#100757

As my `fix` caused more issues than it resolved it's better to revert it.
( rust-lang#103274 rust-lang#104322 rust-lang#104606)

r? `@compiler-errors`

Reopens rust-lang#95134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-medium Medium priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

No branches or pull requests
4 participants
@compiler-errors @Mark-Simulacrum @rustbot @ouz-a