Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug-info/function-arg-initialization.rs is xfail'd #12021

Closed
alexcrichton opened this issue Feb 4, 2014 · 1 comment · Fixed by #12399
Closed

debug-info/function-arg-initialization.rs is xfail'd #12021

alexcrichton opened this issue Feb 4, 2014 · 1 comment · Fixed by #12399
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)

Comments

@alexcrichton
Copy link
Member

Currently the snapshots are blocked on this test passing, so I'm going to xfail it.

The relevant logs are at http://buildbot.rust-lang.org/builders/snap3-linux/builds/619/steps/test/logs/stdio, and the relevant portions of the relevant logs are:

test [debug-info] debug-info/function-arg-initialization.rs ... 
error: line not found in debugger output: $1 = 1
command: gdb -quiet -batch -nx -command=x86_64-unknown-linux-gnu/test/debug-info/function-arg-initialization.debugger.script x86_64-unknown-linux-gnu/test/debug-info/function-arg-initialization.stage2-i686-unknown-linux-gnu
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
x86_64-unknown-linux-gnu/test/debug-info/function-arg-initialization.debugger.script:3: Error in sourced command file:
No line 139 in file "../src/test/debug-info/function-arg-initialization.rs".

------------------------------------------

task '[debug-info] debug-info/function-arg-initialization.rs' failed at 'explicit failure', /home/rustbuild/src/rust-buildbot/slave/snap3-linux/build/src/compiletest/runtest.rs:909
�[31mFAILED�(B�[m

I'm not quite sure why the file can't be found, because I can definitely find the file. I ssh'd into the snap bot and was unable to figure out why gdb didn't want to read that file.

cc @michaelwoerister

@michaelwoerister
Copy link
Member

Hm, I can't reproduce this... I have a small PR in the making. I'd suggest, I re-enable the test with it and we'll see if it passes again.

@bors bors closed this as completed in 5f324aa Feb 20, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
internal: Add a `NameContext` to `CompletionContext`, move out some ImmediateLocation variants

Continues the completion rewrite I started some time ago
(will merge tomorrow after stable since our completion tests still let a lot through)
flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 8, 2024
FP: `needless_return_with_question_mark` with implicit Error Conversion

Return with a question mark was triggered in situations where the `?` desuraging was performing error conversion via `Into`/`From`.

The desugared `?` produces a match over an expression with type `std::ops::ControlFlow<B,C>` with `B:Result<Infallible, E:Error>` and `C:Result<_, E':Error>`, and the arms perform the conversion. The patch adds another check in the lint that checks that `E == E'`. If `E == E'`, then the `?` is indeed unnecessary.

changelog: False Positive: [`needless_return_with_question_mark`] when implicit Error Conversion occurs.

fixes: rust-lang#11982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants