-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coroutine state transform check_must_not_suspend_ty
ignores allocator field of Box
#122643
Comments
Cc @compiler-errors @tmiasko (also a regular occurrence in this file's |
Lol sorry, I thought I had clicked enter on a comment but I must've not. Let me rewrite it.
Yeah, this is approximately the level of urgency you determined. This code exists for an unstable lint, |
… r=oli-obk Detect allocator for box in `must_not_suspend` lint I don't expect this to happen in practice, but better to check than not. Fixes rust-lang#122643
… r=oli-obk Detect allocator for box in `must_not_suspend` lint I don't expect this to happen in practice, but better to check than not. Fixes rust-lang#122643
Rollup merge of rust-lang#122701 - compiler-errors:allocator-suspend, r=oli-obk Detect allocator for box in `must_not_suspend` lint I don't expect this to happen in practice, but better to check than not. Fixes rust-lang#122643
This code here has a potential issue:
rust/compiler/rustc_mir_transform/src/coroutine.rs
Lines 1967 to 1977 in 010f394
If the Box has a custom allocator, then that will not be checked at all. So whatever
check_must_not_suspend_ty
is used for, it ignores anything stored in custom allocators.It seems like this is just for a lint, so this is probably not critical, but I guess should still be fixed.
Cc @cjgillot -- not sure whom else to ping for coroutine state machine transform things?
The text was updated successfully, but these errors were encountered: