Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail with LLVM 19 due to unexpected "'+avx512er' is not a recognized feature for this target (ignoring feature)" output #125492

Closed
zmodem opened this issue May 24, 2024 · 1 comment · Fixed by #125498
Closed

Tests fail with LLVM 19 due to unexpected "'+avx512er' is not a recognized feature for this target (ignoring feature)" output #125492

zmodem opened this issue May 24, 2024 · 1 comment · Fixed by #125498
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@zmodem
Copy link
Contributor

zmodem commented May 24, 2024

For example, from https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/28362

thread 'main' panicked at /var/lib/buildkite-agent/builds/rust-llvm-integrate/llvm-project/rust-llvm-integrate-prototype/tests/run-make/non-unicode-env/rmake.rs:11:5:
assertion `left == right` failed
  left: "'+avx512er' is not a recognized feature for this target (ignoring feature)\n'+avx512er' is not a recognized feature for this target (ignoring feature)\n'+avx512pf' is not a recognized feature for this target (ignoring feature)\n'+avx512pf' is not a recognized feature for this target (ignoring feature)\n'+avx512er' is not a recognized feature for this target (ignoring feature)\n'+avx512er' is not a recognized feature for this target (ignoring feature)\n'+avx512pf' is not a recognized feature for this target (ignoring feature)\n'+avx512pf' is not a recognized feature for this target (ignoring feature)\nerror: environment variable `NON_UNICODE_VAR` is not a valid Unicode string\n --> non_unicode_env.rs:2:13\n  |\n2 |     let _ = env!(\"NON_UNICODE_VAR\");\n  |             ^^^^^^^^^^^^^^^^^^^^^^^\n  |\n  = note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)\n\nerror: aborting due to 1 previous error\n\n"
 right: "error: environment variable `NON_UNICODE_VAR` is not a valid Unicode string\n --> non_unicode_env.rs:2:13\n  |\n2 |     let _ = env!(\"NON_UNICODE_VAR\");\n  |             ^^^^^^^^^^^^^^^^^^^^^^^\n  |\n  = note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)\n\nerror: aborting due to 1 previous error\n\n"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
------------------------------------------

(And many more.)

I think this is due to llvm/llvm-project@4def1ce

Should we just drop these from compiler/rustc_target/src/target_features.rs ?
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 24, 2024
@zmodem
Copy link
Contributor Author

zmodem commented May 24, 2024

cc @durin42 @krasimirgg

zmodem added a commit to zmodem/rust that referenced this issue May 24, 2024
@zmodem
Stop using the avx512er and avx512pf x86 target features
63050af 
They are no longer supported by LLVM 19.

Fixes rust-lang#125492
@zmodem zmodem mentioned this issue May 24, 2024
Merged
@jieyouxu jieyouxu added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels May 24, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this issue May 25, 2024
@workingjubilee
Rollup merge of rust-lang#125498 - zmodem:avx512er, r=workingjubilee
5edded5 
Stop using the avx512er and avx512pf x86 target features

They are no longer supported by LLVM 19.

Fixes rust-lang#125492
workingjubilee added a commit to workingjubilee/rustc that referenced this issue May 25, 2024
@workingjubilee
Rollup merge of rust-lang#125498 - zmodem:avx512er, r=workingjubilee
3e8b60a 
Stop using the avx512er and avx512pf x86 target features

They are no longer supported by LLVM 19.

Fixes rust-lang#125492
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue May 25, 2024
@matthiaskrgr
Rollup merge of rust-lang#125498 - zmodem:avx512er, r=workingjubilee
4d13c96 
Stop using the avx512er and avx512pf x86 target features

They are no longer supported by LLVM 19.

Fixes rust-lang#125492
@bors bors closed this as completed in 3fe3157 May 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue May 25, 2024
@rust-timer
Unrolled build for rust-lang#125498
82824d1 
Rollup merge of rust-lang#125498 - zmodem:avx512er, r=workingjubilee

Stop using the avx512er and avx512pf x86 target features

They are no longer supported by LLVM 19.

Fixes rust-lang#125492
c4rrao pushed a commit to Vudvud/rust that referenced this issue May 25, 2024
@zmodem @c4rrao
Stop using the avx512er and avx512pf x86 target features
8b2ef31 
They are no longer supported by LLVM 19.

Fixes rust-lang#125492
c4rrao pushed a commit to Vudvud/rust that referenced this issue May 25, 2024
@Swatinem @c4rrao
Sync fork
953cc43 
Add a fast-path to `Debug` ASCII `&str`

Instead of going through the `EscapeDebug` machinery, we can just skip over ASCII chars that don’t need any escaping.

Introduce printable-ASCII fast-path for `impl Debug for str`

Instead of having a single loop that works on utf-8 `char`s,
this splits the implementation into a loop that quickly skips over
printable ASCII, falling back to per-char iteration for other chunks.

Switch to primarily using `&str`

Surprisingly, benchmarks have shown that using `&str`
instead of `&[u8]` with some `unsafe` code is actually faster.

Process a single not-ASCII-printable `char` per iteration

This avoids having to collect a non-ASCII-printable run before processing it.

std: simplify key-based thread locals

std: clean up the TLS implementation

Make clamp inline

Run rustfmt on files that need it.

Somehow these files aren't properly formatted. By default `x fmt` and `x
tidy` only check files that have changed against master, so if an
ill-formatted file somehow slips in it can stay that way as long as it
doesn't get modified(?)

I found these when I ran `x fmt` explicitly on every `.rs` file in the
repo, while working on
rust-lang/compiler-team#750.

Fix the dead link in the bootstrap README

Notify kobzol after changes to `opt-dist`

Revert "Rollup merge of rust-lang#123979 - oli-obk:define_opaque_types7, r=compiler-errors"

This reverts commit f939d1f, reversing
changes made to 183c706.

Add regression tests

Only suppress binop error in favor of semicolon suggestion if we're in an assignment statement

compiler: const_eval/transform/validate.rs -> mir_transform/validate.rs

compiler: unnest rustc_const_eval::check_consts

clippy: unnest check_consts

miri: receive the blessings of validate.rs

Migrate `run-make/rustdoc-with-output-dir-option` to `rmake.rs`

Fix some SIMD intrinsics documentation

Actually just remove the special case altogether

rustdoc-json: Add test for keywords with `--document-private-items`

tag more stuff with `WG-trait-system-refactor`

Warn/error on self ctor from outer item in inner item

(Mostly) revert "Account for type param from other item in `note_and_explain`"

This mostly reverts commit 7449478.
It also removes an `opt_param_at` that really is unnecessary given our
ICE policy for malformed intrinsics.

Update cargo

use posix_memalign on most Unix targets

fix typo

Co-authored-by: Jubilee <46493976+workingjubilee@users.noreply.github.com>

Fail relating constants of different types

Use regular type equating instead of a custom query

Bump bootstrap compiler to the latest beta compiler

Remove now outdated comment since we bumped stage0

Stop using the avx512er and avx512pf x86 target features

They are no longer supported by LLVM 19.

Fixes rust-lang#125492

remove proof tree formatter, make em shallow

Don't eagerly monomorphize drop for types that are impossible to instantiate

Better ICE message for unresolved upvars

Structurally resolve before builtin_index in EUV

Add manual Sync impl for ReentrantLockGuard

Fixes: rust-lang#125526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop using the avx512er and avx512pf x86 target features zmodem/rust
3 participants
@zmodem @jieyouxu @rustbot