Stop using the avx512er and avx512pf x86 target features #125498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in tests/ui/check-cfg cc @Urgau |
|
Can someone add the llvm-main label please? |
|
@rustbot +llvm-main |
|
@rustbot label llvm-main |
rustbot
added
the
llvm-main
ytmimi
reviewed
May 24, 2024
This comment has been minimized.
This comment has been minimized.
|
Squash please. |
|
You need to pingback the AVX512 features tracking issue which tracks these as unstable. |
it is possible this does not exist, which would be annoying. |
They are no longer supported by LLVM 19. Fixes rust-lang#125492
Done.
I didn't find one. (But I'm also a newbie here, and not completely sure what I'm looking for..) |
|
these features should have been tracked by #111137 or there should have been another tracking issue for them. |
|
It looks like it simply had gone untracked, which isn't your fault. If LLVM is planning on dropping any other features on the avx512 target feature list here, then letting us know on that tracking issue would be good before we stabilize anything. But this can simply be dropped without notice as it's behind a nightly feature. @bors r+ |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
May 25, 2024
Stop using the avx512er and avx512pf x86 target features They are no longer supported by LLVM 19. Fixes rust-lang#125492
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 25, 2024
…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#124080 (Some unstable changes to where opaque types get defined) - rust-lang#125271 (use posix_memalign on almost all Unix targets) - rust-lang#125433 (A small diagnostic improvement for dropping_copy_types) - rust-lang#125498 (Stop using the avx512er and avx512pf x86 target features) - rust-lang#125510 (remove proof tree formatting, make em shallow) - rust-lang#125513 (Don't eagerly monomorphize drop for types that are impossible to instantiate) - rust-lang#125514 (Structurally resolve before `builtin_index` in EUV) - rust-lang#125515 ( bootstrap: support target specific config overrides ) - rust-lang#125527 (Add manual Sync impl for ReentrantLockGuard) r? `@ghost` `@rustbot` modify labels: rollup
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
May 25, 2024
Stop using the avx512er and avx512pf x86 target features They are no longer supported by LLVM 19. Fixes rust-lang#125492
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 25, 2024
…kingjubilee Rollup of 7 pull requests Successful merges: - rust-lang#125271 (use posix_memalign on almost all Unix targets) - rust-lang#125433 (A small diagnostic improvement for dropping_copy_types) - rust-lang#125498 (Stop using the avx512er and avx512pf x86 target features) - rust-lang#125510 (remove proof tree formatting, make em shallow) - rust-lang#125513 (Don't eagerly monomorphize drop for types that are impossible to instantiate) - rust-lang#125514 (Structurally resolve before `builtin_index` in EUV) - rust-lang#125527 (Add manual Sync impl for ReentrantLockGuard) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 25, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125271 (use posix_memalign on almost all Unix targets) - rust-lang#125451 (Fail relating constants of different types) - rust-lang#125478 (Bump bootstrap compiler to the latest beta compiler) - rust-lang#125498 (Stop using the avx512er and avx512pf x86 target features) - rust-lang#125510 (remove proof tree formatting, make em shallow) - rust-lang#125513 (Don't eagerly monomorphize drop for types that are impossible to instantiate) - rust-lang#125514 (Structurally resolve before `builtin_index` in EUV) - rust-lang#125527 (Add manual Sync impl for ReentrantLockGuard) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 25, 2024
Rollup merge of rust-lang#125498 - zmodem:avx512er, r=workingjubilee Stop using the avx512er and avx512pf x86 target features They are no longer supported by LLVM 19. Fixes rust-lang#125492
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are no longer supported by LLVM 19.
Fixes #125492