Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serve the rust-lang.org domain over https #13180

Closed
thestinger opened this issue Mar 28, 2014 · 17 comments
Closed

serve the rust-lang.org domain over https #13180

thestinger opened this issue Mar 28, 2014 · 17 comments

Comments

@thestinger
Copy link
Contributor

I don't think there's really any need to have http for the site at all. Any non-TLS location is a chance for an attacker to send users to a malicious download.

@thestinger thestinger changed the title serve the entire rust-lang.org domain over https serve the rust-lang.org domain over https Apr 1, 2014
@SimonSapin
Copy link
Contributor

This should apply to all subdomains (www., static., doc., anything else that exists.)

@brson, what’s needed for this to happen?

@SimonSapin
Copy link
Contributor

@brson, This should be closed as duplicate of #16123 which, although more recent, has more discussion.

@huonw huonw closed this as completed Aug 4, 2014
@SimonSapin
Copy link
Contributor

I hadn’t realized that #16123 was only about static.rust-lang.org and links to it. www.rust-lang.org and doc.rust-lang.org should of course be HTTPS as well. Could this be re-opened?

@emberian emberian reopened this Dec 7, 2014
@DomT4
Copy link

DomT4 commented Dec 7, 2014

Presuming the Rust website is hosted and not say, deployed via Github Pages or similar, you could always use Cloudflare to slap SSL/TLS protection across the whole domain, and then you can stick self-signed or CA-signed certs on the server, and you'd have full SSL/TLS protection from user to Cloudflare to server and back the other direction.

If you went with self-signed certs sitting behind the Cloudflare protection, you'd actually spend less per year than it'd cost purchasing a wildcard cert to cover everything. Cloudflare allows you to stick self-signed certs on the server without it raising an enormous browser red-flag.

Reasonably easy to setup, as well.

@SimonSapin
Copy link
Contributor

It might also make sense to use whatever setup we already use for static.rust-lang.org. CC @brson

@brson
Copy link
Contributor

brson commented Dec 8, 2014

The rust website is hosted on GitHub pages. It would need to be hosted somewhere else to serve it over https.

@gsingh93
Copy link
Contributor

It looks really bad when I see a big project like this that still hasn't gotten HTTPS on their website. What exactly is blocking this? It shouldn't be hard to do. If the current hosting can't provide it, it should be changed.

@frewsxcv
Copy link
Member

Related issue: #13180 #17914

@DomT4
Copy link

DomT4 commented Feb 23, 2015

Related issue: #13180

#17914, presumably? :)

@frewsxcv
Copy link
Member

Yes, thanks :)

@brson
Copy link
Contributor

brson commented May 25, 2015

To do this we need to frob the nginx config to redirect www.rust-lang.org to GitHub pages, then update the DNS to point to the nginx server.

@sigmavirus24
Copy link

It'd also be pretty great if Rust became the third language in the "Good" category on https://httpswatch.com/programming#programming-languages

@gsingh93
Copy link
Contributor

I don't want this to come off as aggressive, but I'm genuinely wondering why this is taking so long? This shouldn't take more than 20 minutes to set up. Setting up a MITM attack to change the download links to malicious links is trivial, not to mention not having HTTPS is just plain unprofessional.

@brson
Copy link
Contributor

brson commented Jun 18, 2015

@gsingh93 It's taking a long time because it's not considered a high priority. @edunham has it on her todo list and I expect she'll complete it soon.

@edunham
Copy link
Member

edunham commented Aug 5, 2015

Status: https://www.rust-lang.org/ fixes the original issue of this ticket. http://rust-lang.org redirects to https://www.rust-lang.org. rust-lang/prev.rust-lang.org#165 will handle the issues raised in the ensuing discussion.

At least we're up to "mediocre" on https://httpswatch.com/programming#programming-languages 😒

@gsingh93
Copy link
Contributor

gsingh93 commented Aug 5, 2015

Yay! Nice work!

(This issue should probably be closed now.)

@edunham edunham closed this as completed Aug 5, 2015
@tanriol
Copy link
Contributor

tanriol commented Mar 20, 2016

The github's certificate is still in use for https://blog.rust-lang.org (rust-lang/blog.rust-lang.org#81).

notriddle pushed a commit to notriddle/rust that referenced this issue Sep 20, 2022
…_arg, r=DesmondWillowbrook

New assist: move_format_string_arg

The name might need some improving.

```rust
fn main() {
    print!("{x + 1}");
}
```
to
```rust
fn main() {
    print!("{}"$0, x + 1);
}
```

fixes rust-lang#13180

ref to rust-lang#5988 for similar work

* extracted `format_like`'s parser to it's own module in `ide-db`
* reworked the parser's API to be more direct
* added assist to extract expressions in format args
flip1995 pushed a commit to flip1995/rust that referenced this issue Aug 8, 2024
Simplify lint deprecation

A couple of small changes:
* A few deprecations were changed to renames. They all had a message similar to "this lint has been replaced by ..." which is just describing a rename.
* The website and warning message are now the same. The website description was usually just a wordier version that contained no extra information. This can be worked around if needed, but I don't think that will happen.
* The legacy deprecations have been removed. rustc should handle this since it already suggests adding the `clippy::` for all lints (deprecated or not) when they're used without it. It wouldn't be a problem to add them back in.
* The website no longer has a "view source" link for deprecated lints since they're no longer read from the HIR tree. I could store the line number, but the link seems totally useless for these lints.

This came up as part of separating the internal lints into their own crate. Both the metadata collector and the lint registration code needs access to the deprecated and renamed lists. This form lets all the deprecations be a separate crate.

r? `@flip1995`

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests