Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serve the rust-lang.org domain over https #13180

Closed
thestinger opened this Issue Mar 28, 2014 · 17 comments

Comments

Projects
None yet
@thestinger
Copy link
Contributor

thestinger commented Mar 28, 2014

I don't think there's really any need to have http for the site at all. Any non-TLS location is a chance for an attacker to send users to a malicious download.

@thestinger thestinger changed the title serve the entire rust-lang.org domain over https serve the rust-lang.org domain over https Apr 1, 2014

@SimonSapin

This comment has been minimized.

Copy link
Contributor

SimonSapin commented Jul 28, 2014

This should apply to all subdomains (www., static., doc., anything else that exists.)

@brson, what’s needed for this to happen?

@SimonSapin

This comment has been minimized.

Copy link
Contributor

SimonSapin commented Aug 4, 2014

@brson, This should be closed as duplicate of #16123 which, although more recent, has more discussion.

@huonw huonw closed this Aug 4, 2014

@SimonSapin

This comment has been minimized.

Copy link
Contributor

SimonSapin commented Dec 7, 2014

I hadn’t realized that #16123 was only about static.rust-lang.org and links to it. www.rust-lang.org and doc.rust-lang.org should of course be HTTPS as well. Could this be re-opened?

@cmr cmr reopened this Dec 7, 2014

@DomT4

This comment has been minimized.

Copy link

DomT4 commented Dec 7, 2014

Presuming the Rust website is hosted and not say, deployed via Github Pages or similar, you could always use Cloudflare to slap SSL/TLS protection across the whole domain, and then you can stick self-signed or CA-signed certs on the server, and you'd have full SSL/TLS protection from user to Cloudflare to server and back the other direction.

If you went with self-signed certs sitting behind the Cloudflare protection, you'd actually spend less per year than it'd cost purchasing a wildcard cert to cover everything. Cloudflare allows you to stick self-signed certs on the server without it raising an enormous browser red-flag.

Reasonably easy to setup, as well.

@SimonSapin

This comment has been minimized.

Copy link
Contributor

SimonSapin commented Dec 7, 2014

It might also make sense to use whatever setup we already use for static.rust-lang.org. CC @brson

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Dec 8, 2014

The rust website is hosted on GitHub pages. It would need to be hosted somewhere else to serve it over https.

@gsingh93

This comment has been minimized.

Copy link
Contributor

gsingh93 commented Jan 26, 2015

It looks really bad when I see a big project like this that still hasn't gotten HTTPS on their website. What exactly is blocking this? It shouldn't be hard to do. If the current hosting can't provide it, it should be changed.

@frewsxcv

This comment has been minimized.

Copy link
Member

frewsxcv commented Feb 23, 2015

Related issue: #13180 #17914

@DomT4

This comment has been minimized.

Copy link

DomT4 commented Feb 23, 2015

Related issue: #13180

#17914, presumably? :)

@frewsxcv

This comment has been minimized.

Copy link
Member

frewsxcv commented Feb 23, 2015

Yes, thanks :)

@brson brson referenced this issue May 25, 2015

Closed

Automation metabug #17356

45 of 65 tasks complete
@brson

This comment has been minimized.

Copy link
Contributor

brson commented May 25, 2015

To do this we need to frob the nginx config to redirect www.rust-lang.org to GitHub pages, then update the DNS to point to the nginx server.

@sigmavirus24

This comment has been minimized.

Copy link

sigmavirus24 commented Jun 16, 2015

It'd also be pretty great if Rust became the third language in the "Good" category on https://httpswatch.com/programming#programming-languages

@gsingh93

This comment has been minimized.

Copy link
Contributor

gsingh93 commented Jun 16, 2015

I don't want this to come off as aggressive, but I'm genuinely wondering why this is taking so long? This shouldn't take more than 20 minutes to set up. Setting up a MITM attack to change the download links to malicious links is trivial, not to mention not having HTTPS is just plain unprofessional.

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Jun 18, 2015

@gsingh93 It's taking a long time because it's not considered a high priority. @edunham has it on her todo list and I expect she'll complete it soon.

@edunham

This comment has been minimized.

Copy link
Member

edunham commented Aug 5, 2015

Status: https://www.rust-lang.org/ fixes the original issue of this ticket. http://rust-lang.org redirects to https://www.rust-lang.org. rust-lang/prev.rust-lang.org#165 will handle the issues raised in the ensuing discussion.

At least we're up to "mediocre" on https://httpswatch.com/programming#programming-languages 😒

@gsingh93

This comment has been minimized.

Copy link
Contributor

gsingh93 commented Aug 5, 2015

Yay! Nice work!

(This issue should probably be closed now.)

@edunham edunham closed this Aug 5, 2015

@tanriol

This comment has been minimized.

Copy link

tanriol commented Mar 20, 2016

The github's certificate is still in use for https://blog.rust-lang.org (rust-lang/blog.rust-lang.org#81).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.