Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nested generics for the last field of structs in unsizing. #26038

Merged
merged 1 commit into from
Jun 6, 2015
Merged

Allow nested generics for the last field of structs in unsizing. #26038

merged 1 commit into from
Jun 6, 2015

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Jun 5, 2015

Allows Rc<RefCell<Trait>> and other containers. Fixes #25351.
r? @nrc This is the discussed strategy, more or less.

@luqmana
Copy link
Member

luqmana commented Jun 6, 2015

\o/ @bors: r+

@bors
Copy link
Contributor

bors commented Jun 6, 2015

📌 Commit 01dee1b has been approved by luqmana

@bors
Copy link
Contributor

bors commented Jun 6, 2015

⌛ Testing commit 01dee1b with merge 14d0828...

bors added a commit that referenced this pull request Jun 6, 2015
@bors
Auto merge of #26038 - eddyb:dst-nested, r=luqmana
14d0828 
Allows `Rc<RefCell<Trait>>` and other containers. Fixes #25351.
r? @nrc This is the discussed strategy, more or less.
@bors
Copy link
Contributor

bors commented Jun 6, 2015

💔 Test failed - auto-win-gnu-64-nopt-t

@eddyb
Copy link
Member Author

eddyb commented Jun 6, 2015

@bors retry

bors added a commit that referenced this pull request Jun 6, 2015
@bors
Auto merge of #26038 - eddyb:dst-nested, r=luqmana
ea5523a 
Allows `Rc<RefCell<Trait>>` and other containers. Fixes #25351.
r? @nrc This is the discussed strategy, more or less.
@bors
Copy link
Contributor

bors commented Jun 6, 2015

⌛ Testing commit 01dee1b with merge ea5523a...

@bors
Copy link
Contributor

bors commented Jun 6, 2015

💔 Test failed - auto-linux-32-opt

@eddyb
Copy link
Member Author

eddyb commented Jun 6, 2015

Uhm, cosmic rays? cc @alexcrichton @brson
@bors retry

bors added a commit that referenced this pull request Jun 6, 2015
@bors
Auto merge of #26038 - eddyb:dst-nested, r=luqmana
bfd072d 
Allows `Rc<RefCell<Trait>>` and other containers. Fixes #25351.
r? @nrc This is the discussed strategy, more or less.
@bors
Copy link
Contributor

bors commented Jun 6, 2015

⌛ Testing commit 01dee1b with merge bfd072d...

@bors
Copy link
Contributor

bors commented Jun 6, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt

@bors bors merged commit 01dee1b into rust-lang:master Jun 6, 2015
@eddyb eddyb deleted the dst-nested branch June 6, 2015 18:48
@eddyb eddyb mentioned this pull request Jun 17, 2015
Closed
@eddyb
Copy link
Member Author

eddyb commented Jun 17, 2015

triage: beta-nominated

Found a case where stable (1.0) compiles http://is.gd/BAToXc beta (1.1) doesn't http://is.gd/pnxDTf and nightly (1.2) compiles again http://is.gd/g3dEUF - so this PR actually fixes a regression (@nrc warned me but I had forgotten).

@eddyb eddyb added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 17, 2015
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 18, 2015
@brson
Copy link
Contributor

brson commented Jun 18, 2015

Not backporting per @nrc and @nmatsakis. DST coercions just aren't quite ready for 1.1 and the risk of futzing with them is high.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eddyb @luqmana @bors @brson @nrc