Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize / rewrite filesearch and cstore #2658

Closed
graydon opened this issue Jun 20, 2012 · 10 comments
Closed

Reorganize / rewrite filesearch and cstore #2658

graydon opened this issue Jun 20, 2012 · 10 comments
Labels
A-linkage Area: linking into static, shared libraries and binaries C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot.

Comments

@graydon
Copy link
Contributor

graydon commented Jun 20, 2012

As per fixme, "I'm not happy how this module turned out".
@catamorphism
Copy link
Contributor

Really maturity 2, or maturity 5?

@catamorphism
Copy link
Contributor

Nominating to clear milestone. I think this was mistakenly milestoned.

@graydon
Copy link
Contributor Author

graydon commented Jul 18, 2013

Agreed. Except I also got this as a dupe for triage. @catamorphism can you email me your triage-mail?

@graydon
Copy link
Contributor Author

graydon commented Jul 18, 2013

just a bug, removing milestone/nomination.

@pnkfelix
Copy link
Member

visiting for triage, email from 2013 sep 23.

@pnkfelix
Copy link
Member

(also, I'm inclined to say "If it ain't broke, don't fix it." Someone else can feel free to pick up the baton here, but I don't think this task has a champion, and so I'd prefer to just remove the FIXME and move on.)

((if there were more useful information in this ticket, I'd even suggest leaving the FIXME alone and closing the ticket as wont-fix, but there isn't anything more here than what's in the comment.))

@huonw
Copy link
Member

huonw commented Sep 30, 2013

cc #8652.

@flaper87
Copy link
Contributor

visiting for triage.

I'm inclined to agree with @pnkfelix here. Unless there are bigger issues related to it, I'd recommend not changing it for now. This could also be a good task for an internship program.

@pnkfelix
Copy link
Member

@flaper87 well, I'd only recommend it for the internship program if we have a champion who is willing to mentor the changes. Otherwise, I would still say "lets remove the FIXME here"

@brson
Copy link
Contributor

brson commented Jan 13, 2015

I agree that having this open isn't any use. Everybody knows these modules are crummy, nobody is motivated to do the heroic fix.

@brson brson closed this as completed Jan 13, 2015
@oli-obk oli-obk mentioned this issue Sep 6, 2017
Open
nivkner added a commit to nivkner/rust that referenced this issue Oct 7, 2017
@nivkner
address more FIXME whose associated issues were marked as closed
e0ac65e 
update FIXME(rust-lang#6298) to point to open issue 15020
update FIXME(rust-lang#6268) to point to RFC 811
update FIXME(rust-lang#10520) to point to RFC 1751
remove FIXME for emscripten issue 4563 and include target in `test_estimate_scaling_factor`
remove FIXME(rust-lang#18207) since node_id isn't used for `ref` pattern analysis
remove FIXME(rust-lang#6308) since DST was implemented in rust-lang#12938
remove FIXME(rust-lang#2658) since it was decided to not reorganize module
remove FIXME(rust-lang#20590) since it was decided to stay conservative with projection types
remove FIXME(rust-lang#20297) since it was decided that solving the issue is unnecessary
remove FIXME(rust-lang#27086) since closures do correspond to structs now
remove FIXME(rust-lang#13846) and enable `function_sections` for windows
remove mention of rust-lang#22079 in FIXME(rust-lang#22079) since this is a general FIXME
remove FIXME(rust-lang#5074) since the restriction on borrow were lifted
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@feliperodri
Support for stubbing out foreign functions (rust-lang#2658)
6a151f9 
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linkage Area: linking into static, shared libraries and binaries C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@flaper87 @graydon @brson @pnkfelix @catamorphism @huonw