Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that RwLock might panic #37010

Closed
jethrogb opened this issue Oct 6, 2016 · 2 comments
Closed

Document that RwLock might panic #37010

jethrogb opened this issue Oct 6, 2016 · 2 comments

Comments

@jethrogb
Copy link
Contributor

jethrogb commented Oct 6, 2016

Like a Mutex, RwLock might panic if the current thread already holds a lock. This however is not documented.
@retep998
Copy link
Member

retep998 commented Oct 6, 2016

It might also not panic and simply deadlock. Or it might even cause undefined behavior.

@ghost
Copy link

ghost commented Oct 7, 2016

Additionally error checking is done only on debug mode, so it can silently fail without actually locking anything.

@omern1 omern1 mentioned this issue Oct 13, 2016
Merged
sophiajt pushed a commit to sophiajt/rust that referenced this issue Oct 14, 2016
Rollup merge of rust-lang#37141 - nabeelomer:master, r=sfackler
dd25442 
Documented that RwLock might panic

Fixes rust-lang#37010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @retep998 @jethrogb