Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documented that RwLock might panic #37141

Merged
merged 2 commits into from Oct 15, 2016
Merged

Documented that RwLock might panic #37141

merged 2 commits into from Oct 15, 2016

Conversation

omern1
Copy link
Contributor

@omern1 omern1 commented Oct 13, 2016

Fixes #37010

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sfackler
Copy link
Member

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Oct 13, 2016

📌 Commit b491ddd has been approved by sfackler

@omern1
Copy link
Contributor Author

omern1 commented Oct 14, 2016

@sfackler The checks have passed, please merge the PR.

@sfackler
Copy link
Member

@nabeelomer It is queued to run through the build bots.

@sophiajt sophiajt mentioned this pull request Oct 14, 2016
Merged
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Oct 14, 2016
Rollup merge of rust-lang#37141 - nabeelomer:master, r=sfackler
dd25442 
Documented that RwLock might panic

Fixes rust-lang#37010
bors added a commit that referenced this pull request Oct 14, 2016
@bors
Auto merge of #37170 - jonathandturner:rollup, r=jonathandturner
a8d189a 
Rollup of 10 pull requests

- Successful merges: #36307, #36755, #36961, #37102, #37115, #37119, #37122, #37123, #37141, #37159
- Failed merges:
@bors bors merged commit b491ddd into rust-lang:master Oct 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@omern1 @rust-highfive @sfackler @bors