Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[deny(non_camel_case_types)] is too aggressive #41621

Closed
whitequark opened this issue Apr 29, 2017 · 0 comments · Fixed by #46907
Closed

#[deny(non_camel_case_types)] is too aggressive #41621

whitequark opened this issue Apr 29, 2017 · 0 comments · Fixed by #46907
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug.

Comments

@whitequark
Copy link
Member

Specifically, there are snake_case names that cannot be converted into CamelCase (as interpreted by this lint) without losing semantics: anything that contains two numbers with a separator. E.g foo_4_20 does not have a CamelCase equivalent that's accepted by the lint but is not confusable with the conversion result of foo_420.

Originally discovered in rust-embedded/svd2rust#76.
@Mark-Simulacrum Mark-Simulacrum added the A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. label Jun 22, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Jul 27, 2017
@varkor varkor mentioned this issue Dec 21, 2017
Merged
kennytm added a commit to kennytm/rust that referenced this issue Jan 4, 2018
@kennytm
Rollup merge of rust-lang#46907 - varkor:contrib-8, r=nagisa
ba11790 
Allow non-alphabetic underscores in camel case

Certain identifiers, such as `X86_64`, cannot currently be unambiguously represented in camel case (`X8664`, `X86_64`, `X8_664`, etc. are all transformed to the same identifier). This change relaxes the rules so that underscores are permitted between two non-alphabetic characters under `#[forbid(non_camel_case_types)]`. Fixes rust-lang#34633 and fixes rust-lang#41621.
bors added a commit that referenced this issue Jan 5, 2018
@bors
Auto merge of #46907 - varkor:contrib-8, r=nagisa
8a11b8c 
Allow non-alphabetic underscores in camel case

Certain identifiers, such as `X86_64`, cannot currently be unambiguously represented in camel case (`X8664`, `X86_64`, `X8_664`, etc. are all transformed to the same identifier). This change relaxes the rules so that underscores are permitted between two non-alphabetic characters under `#[forbid(non_camel_case_types)]`. Fixes #34633 and fixes #41621.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow non-alphabetic underscores in camel case varkor/rust
2 participants
@whitequark @Mark-Simulacrum