Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rustbuild] LLVM seems to not be rebuilt when submodule changes #42405

Closed
nagisa opened this issue Jun 3, 2017 · 1 comment · Fixed by #59303
Closed

[rustbuild] LLVM seems to not be rebuilt when submodule changes #42405

nagisa opened this issue Jun 3, 2017 · 1 comment · Fixed by #59303
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@nagisa
Copy link
Member

nagisa commented Jun 3, 2017

I

  • Changed the submodule, commited the changes;
  • Commited the submodule commit change in the rust repo;
  • Built.

Rustbuild did not seem to pick up on the submodule being changed.
@petrochenkov
Copy link
Contributor

petrochenkov commented Jun 3, 2017 •
edited
Loading

LLVM rebuild is currently triggered only when contents of llvm-rebuild-trigger and llvm-finished-building stamps disagree (including llvm-finished-building being non-existent), so it's always manual.

Full checking of something in LLVM being outdated is not performed because it's expensive thing to do on every build, but the submodule state check can be performed I guess.

@sanxiyn sanxiyn added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jun 9, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 27, 2017
@Mark-Simulacrum Mark-Simulacrum added this to the impl period milestone Sep 15, 2017
@aturon aturon removed this from the impl period milestone Sep 15, 2017
@euclio euclio mentioned this issue Mar 19, 2019
Merged
bors added a commit that referenced this issue Mar 29, 2019
@bors
Auto merge of #59303 - euclio:remove-rebuild-trigger, r=cuviper
2002b4b 
replace llvm-rebuild-trigger with submodule commit hash

As mentioned in #59285.

This PR removes the need to update the `llvm-rebuild-trigger` file. Instead, the latest commit hash of the appropriate LLVM submodule will be stored in the stamp file and used to detect if a build is required.

Fixes #42405.
Fixes #54959.
Fixes #55537.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace llvm-rebuild-trigger with submodule commit hash euclio/rust
5 participants
@sanxiyn @nagisa @aturon @Mark-Simulacrum @petrochenkov