Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary use of #[reexport_test_harness_main] in test #43219

Closed
cptroot opened this issue Jul 13, 2017 · 3 comments
Closed

Unnecessary use of #[reexport_test_harness_main] in test #43219

cptroot opened this issue Jul 13, 2017 · 3 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@cptroot
Copy link

cptroot commented Jul 13, 2017

While trying to figure out what the #[reexport_test_harness_main] attribute did, I ran across this line of code.

https://github.com/rust-lang/rust/blob/master/src/test/run-pass/core-run-destroy.rs#L18

Near as I can tell, the reference to #[reexport_test_harness_main] here doesn't do anything, and can be removed for clarity.
@Mark-Simulacrum Mark-Simulacrum added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Jul 19, 2017
@Mark-Simulacrum
Copy link
Member

Marking as an easy issue since it seems that removing that line is all that would need to be done here, and then if CI passes, great, if not, then we shouldn't remove it. Willing to mentor as well.

@Mark-Simulacrum Mark-Simulacrum added the E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. label Jul 19, 2017
@shivanth
Copy link

I take this up 😄

marioidival added a commit to marioidival/rust that referenced this issue Aug 2, 2017
@marioidival
Remove unecessary test code rust-lang#43219
fefe63c
@marioidival marioidival mentioned this issue Aug 2, 2017
Merged
bors added a commit that referenced this issue Aug 2, 2017
@bors
Auto merge of #43607 - marioidival:master, r=alexcrichton
4596c71 
Remove unecessary test code #43219

related #43219
@marioidival
Copy link
Member

@Mark-Simulacrum close?

@sfackler sfackler closed this as completed Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@shivanth @marioidival @cptroot @sfackler @Mark-Simulacrum