Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for DoubleEndedIterator::rfold (feature `iter_rfold`) #44705

Closed
bluss opened this Issue Sep 19, 2017 · 8 comments

Comments

Assignees
No one assigned
Labels
B-unstable C-tracking-issue T-libs final-comment-period
Projects
None yet
Milestone
No milestone
7 participants
@bluss @scottmcm @SimonSapin @rfcbot @withoutboats @TimNN @sfackler
@bluss
Copy link
Contributor

bluss commented Sep 19, 2017 •
edited

This is a tracking issue for DoubleEndedIterator::rfold (feature iter_rfold)

@sfackler sfackler added B-unstable T-libs labels Sep 19, 2017

@TimNN TimNN added the C-tracking-issue label Sep 20, 2017

@bluss

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

bluss commented Oct 2, 2017

More rfold impls in #44856

@cuviper cuviper referenced this issue Nov 8, 2017

Closed

Tracking issue for Iterator::try_fold and try_rfold (feature iterator_try_fold) #45594

1 of 4 tasks complete
@scottmcm

This comment has been minimized.

Sign in to view
Copy link
Member

scottmcm commented Nov 19, 2017

Is this ready for a stabilization PR? I don't think there are any open questions...
@bluss

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

bluss commented Nov 19, 2017

I'd love to see this stabilized too.

The trait question where to place it (same as rfind) is the only one. I'm interested in what others think about that.
@SimonSapin

This comment has been minimized.

Sign in to view
Copy link
Contributor

SimonSapin commented Mar 17, 2018

Looks good to me to stabilize.

@rfcbot fcp merge
@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Mar 17, 2018 •
edited by aturon

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period label Mar 17, 2018

@withoutboats

This comment has been minimized.

Sign in to view
Copy link
Contributor

withoutboats commented Mar 17, 2018

I'm glad this was implemented on DoubleEndedIterator. The more niche methods are added to Iterator, the harder it is for users (especially new users) to find the non-niche method they're looking for. Since this method is extremely niche (an optimization of a very uncommon operation - folding in reverse), I think it would be "method bloat" to add it to Iterator.

I'm just noting this because I was going to register a concern about adding this to Iterator until I saw that it was added to DoubleEndedIterator instead.

@scottmcm scottmcm referenced this issue Mar 17, 2018

Closed

Tracking issue for (DoubleEnded)?Iterator::rfind #39480

@rfcbot rfcbot added final-comment-period and removed proposed-final-comment-period labels Mar 17, 2018

@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Mar 17, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔
@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Mar 27, 2018

The final comment period is now complete.

@cuviper cuviper referenced this issue Apr 3, 2018

Merged

Stabilize iterator methods in 1.27 #49607

kennytm added a commit to kennytm/rust that referenced this issue Apr 4, 2018

@kennytm
Rollup merge of rust-lang#49607 - cuviper:stable-iter-1.27, r=alexcri… 
…chton

Stabilize iterator methods in 1.27

- Closes rust-lang#39480, feature  `iter_rfind`
  - `DoubleEndedIterator::rfind`
- Closes rust-lang#44705, feature `iter_rfold`
  - `DoubleEndedIterator::rfold`
- Closes rust-lang#45594, feature `iterator_try_fold`
  - `Iterator::try_fold`
  - `Iterator::try_for_each`
  - `DoubleEndedIterator::try_rfold`
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
dd2ec6a

@alexcrichton alexcrichton closed this in #49607 Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.