New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for DoubleEndedIterator::rfold (feature `iter_rfold`) #44705

Closed
bluss opened this Issue Sep 19, 2017 · 8 comments

Comments

Projects
None yet
7 participants
@bluss
Contributor

bluss commented Sep 19, 2017

This is a tracking issue for DoubleEndedIterator::rfold (feature iter_rfold)

@bluss

This comment has been minimized.

Show comment
Hide comment
@bluss

bluss Oct 2, 2017

Contributor

More rfold impls in #44856

Contributor

bluss commented Oct 2, 2017

More rfold impls in #44856

@scottmcm

This comment has been minimized.

Show comment
Hide comment
@scottmcm

scottmcm Nov 19, 2017

Member

Is this ready for a stabilization PR? I don't think there are any open questions...

Member

scottmcm commented Nov 19, 2017

Is this ready for a stabilization PR? I don't think there are any open questions...

@bluss

This comment has been minimized.

Show comment
Hide comment
@bluss

bluss Nov 19, 2017

Contributor

I'd love to see this stabilized too.

The trait question where to place it (same as rfind) is the only one. I'm interested in what others think about that.

Contributor

bluss commented Nov 19, 2017

I'd love to see this stabilized too.

The trait question where to place it (same as rfind) is the only one. I'm interested in what others think about that.

@SimonSapin

This comment has been minimized.

Show comment
Hide comment
@SimonSapin

SimonSapin Mar 17, 2018

Contributor

Looks good to me to stabilize.

@rfcbot fcp merge

Contributor

SimonSapin commented Mar 17, 2018

Looks good to me to stabilize.

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Mar 17, 2018

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot commented Mar 17, 2018

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@withoutboats

This comment has been minimized.

Show comment
Hide comment
@withoutboats

withoutboats Mar 17, 2018

Contributor

I'm glad this was implemented on DoubleEndedIterator. The more niche methods are added to Iterator, the harder it is for users (especially new users) to find the non-niche method they're looking for. Since this method is extremely niche (an optimization of a very uncommon operation - folding in reverse), I think it would be "method bloat" to add it to Iterator.

I'm just noting this because I was going to register a concern about adding this to Iterator until I saw that it was added to DoubleEndedIterator instead.

Contributor

withoutboats commented Mar 17, 2018

I'm glad this was implemented on DoubleEndedIterator. The more niche methods are added to Iterator, the harder it is for users (especially new users) to find the non-niche method they're looking for. Since this method is extremely niche (an optimization of a very uncommon operation - folding in reverse), I think it would be "method bloat" to add it to Iterator.

I'm just noting this because I was going to register a concern about adding this to Iterator until I saw that it was added to DoubleEndedIterator instead.

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Mar 17, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot commented Mar 17, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Mar 27, 2018

The final comment period is now complete.

rfcbot commented Mar 27, 2018

The final comment period is now complete.

kennytm added a commit to kennytm/rust that referenced this issue Apr 4, 2018

Rollup merge of rust-lang#49607 - cuviper:stable-iter-1.27, r=alexcri…
…chton

Stabilize iterator methods in 1.27

- Closes rust-lang#39480, feature  `iter_rfind`
  - `DoubleEndedIterator::rfind`
- Closes rust-lang#44705, feature `iter_rfold`
  - `DoubleEndedIterator::rfold`
- Closes rust-lang#45594, feature `iterator_try_fold`
  - `Iterator::try_fold`
  - `Iterator::try_for_each`
  - `DoubleEndedIterator::try_rfold`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment