Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"newtype" structs fail to work across crates #4577

Closed
ghost opened this issue Jan 22, 2013 · 7 comments
Closed

"newtype" structs fail to work across crates #4577

ghost opened this issue Jan 22, 2013 · 7 comments
Labels
A-linkage Area: linking into static, shared libraries and binaries A-typesystem Area: The type system

Comments

@ghost
Copy link

ghost commented Jan 22, 2013

a.rs:

pub struct Foo { x : int }
pub struct Bar( int );

b.rs:

extern mod a;
use a::*;

fn main() {
    let foo = Foo { x : 0 };
    let bar = Bar( 0 );
}

rustc --lib a.rs && rustc -L. b.rs yields:

b.rs:6:11: 6:14 error: unresolved name: Bar
b.rs:6  let bar = Bar( 0 );
                  ^~~
@ghost ghost assigned catamorphism Jan 24, 2013
@catamorphism
Copy link
Contributor

I'll take a look.

@graydon
Copy link
Contributor

graydon commented Mar 25, 2013

reproduced on 2013-03-25

@graydon
Copy link
Contributor

graydon commented Mar 25, 2013

non-critical for 0.6, de-milestoning

@graydon
Copy link
Contributor

graydon commented Mar 25, 2013

reproduced on 2013-03-25

@graydon
Copy link
Contributor

graydon commented Mar 25, 2013

non-critical for 0.6, de-milestoning

@catamorphism
Copy link
Contributor

May be a dup of #4545

@msullivan
Copy link
Contributor

This seems fixed.

@ghost ghost unassigned catamorphism Jun 16, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
Switch to GitHub Actions - Part 2 - From within

This is a continuation of rust-lang#5071. This time from a branch inside the rust-lang/rust-clippy repo, not from my fork, since secrets are not available in PRs from forks.

Copying the description of rust-lang#5071 to here:

Closes rust-lang#4577

~~This is just an experiment. I don't think we have a consensus _if_ we should move away from travis/appveyor.~~ We have consensus: rust-lang/rust-clippy#5071 (comment)

~~GHA would let us run up to 20 concurrent jobs. Since we have 15 integration tests and 4 (linux, linux 32-bit, macos, windows) basic tests, we would be able to run everything concurrently.~~ The org has a limit of 60 jobs across the org, so we limit the matrix of the integration tests to 6 concurrent jobs.

~~Also IIUC we only have to build Clippy once for every initegration test and then only check the repos.~~ Nope, dependent jobs exist, but they won't keep the artifacts (not even the checkout).

TODO before merge:

- [x] Add `DEPLOY_KEY` secret to github repo
- [x] test deployment on test branch `gh-test`#
  - [x] Test normal deployment
  - [x] Test deployment no changes
  - [x] Test deployment of tag
- [x] talk with `@rust-lang/infra` for bors, `@rust-lang/infra` is good with the move (crater also uses GHA+bors)
- [x] ~~Get remark + clippy_dev check to work on pushes (https://github.community/t5/GitHub-Actions/~Builds-are-not-triggered-with-on-paths/m-p/44075; I contacted GH support about this) ~~That seems to start working again yesterday. Let's hope it keeps working.~~ Or not: df9be48. Now it works again: 723786a. I think we should wait, until this is reliable. It appears, that it doesn't work on force pushes (sometimes?): 5814142~~ We need to run the bors tests unconditionally anyway (47138d1) so it doesn't really matter.
- [x] ~~impl homu checks for GHA rust-lang/rust-clippy#5071 (comment) -- I prepared: flip1995/rust-central-station@f40230d. I'd suggest to first add GHA and keep the travis and appveyor checks for a few days and to remove them in a second pass. The bors dummy jobs are added in rust-lang/rust-clippy@1a83b7a and work as expected: rust-lang/rust-clippy#5088 (comment). I opened rust-lang/rust-central-station#578 See rust-lang/rust-clippy#5088 (comment)
- [x] ~Add GHA badge to Cargo.toml (blocked on rust-lang/crates.io # 1838)~ Added a FIXME in
2332b57
- [x] ~Maybe we should also wait until GHA supports yaml anchors. https://github.community/t5/GitHub-Actions/Support-for-YAML-anchors/td-p/30336/~ WIll probably not be implemented in the near future.
- [x] Add back travis + appveyor files for transition period (!)

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linkage Area: linking into static, shared libraries and binaries A-typesystem Area: The type system
Projects
None yet
Development

No branches or pull requests

3 participants