Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span to E0391 #52417

Closed
estebank opened this issue Jul 16, 2018 · 2 comments
Closed

Add span to E0391 #52417

estebank opened this issue Jul 16, 2018 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@estebank
Copy link
Contributor

Current output:

error[E0391]: cycle detected when computing layout of `std::option::Option<S>`
   |
note: ...which requires computing layout of `S`...
   = note: ...which again requires computing layout of `std::option::Option<S>`, completing the cycle
note: cycle used when compile_codegen_unit
@estebank estebank added the A-diagnostics Area: Messages for errors, warnings, and lints label Jul 16, 2018
@euclio
Copy link
Contributor

euclio commented Sep 14, 2018

I took a look at this, and it looks like calls to the layout_of query need to be associated with a span. However, I'm not familiar enough with the query system to figure out how to do that. Looks like the normalization query needs a span as well.

@JohnTitor JohnTitor added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 19, 2019
@estebank
Copy link
Contributor Author

estebank commented Feb 3, 2023

This has since been fixed.

@estebank estebank closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants