Move some compile-fail tests to ui
#52409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebank
commented
Jul 15, 2018
| @@ -1,31 +0,0 @@ | |||
| // Copyright 2014 The Rust Project Developers. See the COPYRIGHT | |||
There was a problem hiding this comment.
The deleted files (such as this one) are moves with changes.
There was a problem hiding this comment.
why were they changed?
and why in a single commit? 😢
There was a problem hiding this comment.
I had to add the error note check, as they were relying only on regex matching the output. I couldn't tell in advance whether a given test would need to be changed before running them as ui. I can rewrite the commit history to do so later.
|
r? @oli-obk |
This comment has been minimized.
This comment has been minimized.
oli-obk
approved these changes
Jul 15, 2018
| // We only want to assert that this doesn't ICE, we don't particularly care | ||
| // about whether it nor it fails to compile. | ||
|
|
||
| // error-pattern: |
There was a problem hiding this comment.
this is not needed anymore
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| // This file must never have a trailing newline |
There was a problem hiding this comment.
that comment is weird. no explanation and the file does have a trailing newline, altough not a full extra empty line at the end
There was a problem hiding this comment.
to be fair, the name of the file does lead us to #11493, which explicitly said that to reproduce the bug in question, we needed to have a file with no trailing newline...
| | `+` can't be used to concatenate two `&str` strings | ||
| help: `to_owned()` can be used to create an owned `String` from a string reference. String concatenation appends the string on the right to the string on the left and may require reallocation. This requires ownership of the string on the left | ||
| | | ||
| LL | a.to_owned() += { "b" }; |
There was a problem hiding this comment.
Open an issue about this wrong suggestion
| error: compilation successful | ||
| --> $DIR/issue-11740.rs:35:1 | ||
| | | ||
| LL | / fn main() { //~ ERROR compilation successful |
There was a problem hiding this comment.
this should probably be a // compile-pass test
| --> $DIR/issue-12997-2.rs:16:1 | ||
| | | ||
| LL | fn bar(x: isize) { } | ||
| | ^^^^^^^^^^^^^^^^^^^^ expected isize, found mutable reference |
There was a problem hiding this comment.
This span is weird and the message is inverted. Should probably also open an issue about it
| error: compilation successful | ||
| --> $DIR/issue-40510-4.rs:25:1 | ||
| | | ||
| LL | fn main() {} //~ ERROR compilation successful |
| error: compilation successful | ||
| --> $DIR/issue-41998.rs:14:1 | ||
| | | ||
| LL | / fn main() { //~ ERROR compilation successful |
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| //~^^^^^^^^^^ ERROR cycle detected when computing layout of |
| error: unnecessary `unsafe` block | ||
| --> $DIR/issue-48131.rs:18:9 | ||
| | | ||
| LL | unsafe { /* unnecessary */ } //~ ERROR unnecessary `unsafe` |
There was a problem hiding this comment.
this could have a structured suggestion
| | | | ||
| | cannot use `+=` on type `T` | ||
| | | ||
| = note: `T` might need a bound for `std::ops::AddAssign` |
There was a problem hiding this comment.
another suggestion would be to manually expand to x = x + y if a bound for Add is there
|
Thank you for the thorough checking of the output! That's part of why I wanted to move to |
|
@bors r=oli-obk p=10 |
|
📌 Commit 2332759 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 2332759 with merge c2735d26cc9ae5b42d11af7d8f080fec8aa84bfb... |
|
💔 Test failed - status-travis |
bors
removed
the
S-waiting-on-bors
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors r+ p=10 |
|
📌 Commit f760960 has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- |
bors
added
S-waiting-on-author
|
@bors r=oli-obk p=10 |
|
📌 Commit f760960 has been approved by |
bors
removed
the
S-waiting-on-author
bors
added
S-waiting-on-review
|
kennytm
added
S-waiting-on-author
|
@bors r=oli-obk p=10 |
|
📌 Commit e0b54b5411a286f16ad89a10684dc42daa1750ec has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit e0b54b5411a286f16ad89a10684dc42daa1750ec with merge 89c20aef0cb1552111fe1b549b193b905240ab13... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
1 similar comment
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors r+ p=10 |
|
📌 Commit 82fd8d7 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 17, 2018
Move some `compile-fail` tests to `ui` Re: #44844.
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #44844.