Add help message for missing IndexMut impl with NLL #53830

davidtwco · 2018-08-30T17:47:19Z

rust-highfive · 2018-08-30T17:58:46Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.


[00:05:13] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:05:13] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:411: trailing whitespace
[00:05:13] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:415: trailing whitespace
[00:05:13] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:416: trailing whitespace
[00:05:14] some tidy checks failed
[00:05:14] 
[00:05:14] 
[00:05:14] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:05:14] 
[00:05:14] 
[00:05:14] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:14] Build completed unsuccessfully in 0:00:55
[00:05:14] Build completed unsuccessfully in 0:00:55
[00:05:14] Makefile:79: recipe for target 'tidy' failed
[00:05:14] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:24bbee31
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0bb76fd0:start=1535651708407390286,finish=1535651708413681767,duration=6291481
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0dd29670
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:01e82c08
travis_time:start:01e82c08
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1c067a0e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-08-30T18:18:53Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:13:11]    Compiling rustc_metadata_utils v0.0.0 (file:///checkout/src/librustc_metadata_utils)
[00:13:11]    Compiling rustc_mir v0.0.0 (file:///checkout/src/librustc_mir)
[00:13:11]    Compiling rustc_typeck v0.0.0 (file:///checkout/src/librustc_typeck)
[00:13:12]    Compiling rustc_traits v0.0.0 (file:///checkout/src/librustc_traits)
[00:13:52] error[E0502]: cannot borrow `self.mir` as immutable because `*self` is also borrowed as mutable
[00:13:52]     --> librustc_mir/borrow_check/mod.rs:1605:49
[00:13:52] 1604 |             self.report_illegal_reassignment(
[00:13:52]      |             ---- mutable borrow occurs here
[00:13:52]      |             ---- mutable borrow occurs here
[00:13:52] 1605 |                 context, place_span, init.span(&self.mir), place_span.0
[00:13:52] 1606 |             );
[00:13:52] 1606 |             );
[00:13:52]      |             - mutable borrow ends here
[00:13:56] error: aborting due to previous error
[00:13:56] 
[00:13:56] For more information about this error, try `rustc --explain E0502`.
[00:13:56] error: Could not compile `rustc_mir`.
[00:13:56] error: Could not compile `rustc_mir`.
[00:13:56] 
[00:13:56] Caused by:
[00:13:56]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name rustc_mir librustc_mir/lib.rs --color always --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=7952c237ec0d4952 -C extra-filename=-7952c237ec0d4952 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern arena=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libarena-4ee92b74dcb65ca6.so --extern bitflags=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbitflags-5a39798fe03e47f4.rlib --extern byteorder=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbyteorder-8246be02936c9b1b.rlib --extern either=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libeither-0a515e87c8afea9e.rlib --extern graphviz=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libgraphviz-45ae4394366d07fd.so --extern log=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-c55d6c95192e4906.rlib --extern log_settings=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog_settings-87ec950697a15ed0.rlib --extern polonius_engine=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libpolonius_engine-218f3033f29f5493.rlib --extern rustc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc-cfbc17aa3c766576.so --extern rustc_apfloat=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_apfloat-4a211d9e23f5aeb5.rlib --extern rustc_data_structures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_data_structures-61336079186baa43.so --extern rustc_errors=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-f882aab6100635ab.so --extern rustc_target=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_target-51fd1bd0441a9815.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-8d84add221c0f710.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-8d84add221c0f710.rlib --extern smallvec=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsmallvec-cb741677cd0e0351.rlib --extern syntax=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-26b6009735d1b07c.so --extern syntax_pos=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-ef45b71e578357b1.so -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/backtrace-sys-ee16f6821aef40e9/out -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/miniz-sys-52504d5ed57fefc2/out` (exit code: 1)
isk usage after running script:"; df -h; du . | sort -nr | head -n100

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

davidtwco · 2018-08-30T18:20:58Z

Huh, strange. I'll rebase locally and see if I can reproduce.

… Init

nikomatsakis

what do you think? maybe make a test for a manual call using Index::index?

src/test/ui/issues/issue-41726.nll.stderr

nikomatsakis

Not sure whether I'm suggesting you do this or not, have to think about it.

In any case, I like the error.

nikomatsakis · 2018-08-31T14:31:59Z

src/librustc_mir/borrow_check/mutability_errors.rs

+                            if self.tcx.parent(id) == self.tcx.lang_items().index_trait() {
+
+                                let mut found = false;
+                                self.tcx.for_each_relevant_impl(


Hmm, this check is pretty crude. I guess it'll work, but (e.g.) if IndexMut is implemented, but for a different index type, it will get the wrong result (though that is likely to get a different error, earlier in the compiler).

Another option might be to use the predicate_may_hold method (or perhaps predicate_must_hold) to test if the trait holds.

It's a bit more work though — we'd have to construct the proper predicate and everything. Seems like something where some helper functions would be useful, I feel like this comes up from time to time in the code.

We've discovered that due to a bug in the canonicalization code, it's not possible to switch to predicate_may_hold at the moment - the code that demonstrated this is available on this branch.

nikomatsakis · 2018-09-06T19:20:56Z

@bors r+

bors · 2018-09-06T19:20:57Z

📌 Commit 08a4a37 has been approved by nikomatsakis

Mark-Simulacrum · 2018-09-07T01:40:54Z

@bors p=1 RC milestone fix

bors · 2018-09-07T01:49:40Z

⌛ Testing commit 08a4a37 with merge aacf17bb775f952ee54ab3322df68553fe929826...

bors · 2018-09-07T01:52:18Z

💔 Test failed - status-travis

rust-highfive · 2018-09-07T01:52:20Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-09-07T07:18:20Z

@bors retry

An error occurred while generating the build script.

bors · 2018-09-07T09:57:35Z

⌛ Testing commit 08a4a37 with merge 7366752...

@nikomatsakis

Add help message for missing IndexMut impl with NLL Fixes #53228. r? @nikomatsakis

bors · 2018-09-07T12:48:14Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 7366752 to master...

rust-highfive assigned nikomatsakis Aug 30, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2018

davidtwco force-pushed the issue-53228 branch from fda110a to 46cf81a Compare August 30, 2018 18:01

Added InitLocation to encode Location or Local depending on source of…

ef6851c

… Init

nikomatsakis requested changes Aug 30, 2018

View reviewed changes

src/test/ui/issues/issue-41726.nll.stderr Show resolved Hide resolved

Added help message for missing IndexMut impl.

1ad2f5c

davidtwco force-pushed the issue-53228 branch from 46cf81a to 1ad2f5c Compare August 30, 2018 19:44

Omit 'missing IndexMut impl' suggestion when IndexMut is implemented.

08a4a37

nikomatsakis reviewed Aug 31, 2018

View reviewed changes

memoryruins added the A-NLL Area: Non Lexical Lifetimes (NLL) label Aug 31, 2018

nikomatsakis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 6, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 7, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2018

kennytm mentioned this pull request Sep 7, 2018

Rollup of 17 pull requests #54021

Merged

bors added a commit that referenced this pull request Sep 7, 2018

Auto merge of #53830 - davidtwco:issue-53228, r=nikomatsakis

7366752

Add help message for missing IndexMut impl with NLL Fixes #53228. r? @nikomatsakis

bors merged commit 08a4a37 into rust-lang:master Sep 7, 2018

davidtwco deleted the issue-53228 branch September 7, 2018 18:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add help message for missing IndexMut impl with NLL #53830

Add help message for missing IndexMut impl with NLL #53830

davidtwco commented Aug 30, 2018

rust-highfive commented Aug 30, 2018

rust-highfive commented Aug 30, 2018

davidtwco commented Aug 30, 2018

nikomatsakis left a comment

nikomatsakis left a comment

nikomatsakis Aug 31, 2018

davidtwco Sep 5, 2018

nikomatsakis commented Sep 6, 2018

bors commented Sep 6, 2018

Mark-Simulacrum commented Sep 7, 2018

bors commented Sep 7, 2018

bors commented Sep 7, 2018

rust-highfive commented Sep 7, 2018

kennytm commented Sep 7, 2018

bors commented Sep 7, 2018

bors commented Sep 7, 2018

Add help message for missing IndexMut impl with NLL #53830

Add help message for missing IndexMut impl with NLL #53830

Conversation

davidtwco commented Aug 30, 2018

rust-highfive commented Aug 30, 2018

rust-highfive commented Aug 30, 2018

davidtwco commented Aug 30, 2018

nikomatsakis left a comment

Choose a reason for hiding this comment

nikomatsakis left a comment

Choose a reason for hiding this comment

nikomatsakis Aug 31, 2018

Choose a reason for hiding this comment

davidtwco Sep 5, 2018

Choose a reason for hiding this comment

nikomatsakis commented Sep 6, 2018

bors commented Sep 6, 2018

Mark-Simulacrum commented Sep 7, 2018

bors commented Sep 7, 2018

bors commented Sep 7, 2018

rust-highfive commented Sep 7, 2018

kennytm commented Sep 7, 2018

bors commented Sep 7, 2018

bors commented Sep 7, 2018