Rollup of 17 pull requests #54021
Merged
Rollup of 17 pull requests #54021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the clippy "single_char_pattern" lint, and (marginally) improves performance.
Fixes a clippy warning, and improves readability.
Use `.nth(n)` rather than `.skip(n).next()` (also fixes a clippy warning), and use `.into()` and a type signature rather than `PathBuf::from`.
Eliminates a clippy warning. Also drop the unnecessary `.peekable()`.
Also eliminates a clippy lint.
…fetimes Dropping the redundant lifetimes also eliminates a clippy warning.
This also eliminates a clippy warning.
Drop unnecessary .into_iter() (also fixing a clippy warning), and use path functions to handle file extensions.
This makes the code more readable, and eliminates a clippy warning.
This improves readability and eliminates a clippy warning.
Use `if let` to simplify a match, and use `contains_key` instead of `get`.
The match expression immediately below it checks the same condition.
Mention that you can use `into_inner` to drop the contained value.
Fixes a problem where submodules could not be cloned under some git configurations. Specifically, when url.git@github.com:.insteadOf = https://github.com/ is set.
bors
added
S-waiting-on-review
Closed
Clarify `ManuallyDrop` docs Mention that you can use `into_inner` to drop the contained value.
…y-test, r=wesleywiser Minimized clippy test from when NLL disabled two-phase borrows (Of course anyone even skimming the test will realize that this is an *expansion* of a previously posted [minimization](rust-lang#52934 (comment)).) Fix rust-lang#52934.
Add .git extension to submodule paths missing it Fixes a problem where submodules could not be cloned under some git configurations. Specifically, when url.git@github.com:.insteadOf = https://github.com/ is set.
…ebank A few cleanups and minor improvements to mir/dataflow - simplify `dot::GraphWalk::edges` and optimize its vector's allocation - turn a `kill` loop into `kill_all` - remove the `prepost` parameter from `dataflow_path` (it doesn't seem to do anything) - a couple of other minor improvements
…alexcrichton propagate build.python into cmake If a suitable value of Python is not on `PATH`, one can still invoke x.py manually, which propagates `BOOTSTRAP_PYTHON` into the bootstrap environment. But building LLVM will abort with error messages about not being able to find Python, and instructions to set `PYTHON_EXECUTABLE`, because nothing is done with `BOOTSTRAP_PYTHON` when invoking cmake. Setting `build.python` in config.toml had no effect in this scenario, either To fix this, let's provide `PYTHON_EXECUTABLE` when invoking cmake; for the "normal" case of Python in `PATH`, this doesn't alter any behavior. For more unusual cases, however, this ensures cmake finds Python properly. (This change also ensures there are no differences between what bootstrap is using, and what cmake uses, which may be useful for consistency's sake.)
…t-atomics-master, r=sfackler Remove `#[repr(transparent)]` from atomics Added in rust-lang#52149 the discussion in rust-lang#53514 is showing how we may not want to actually add this attribute to the atomic types. While we continue to debate rust-lang#53514 this commit reverts the addition of the `transparent` attribute. This should be a more conservative route which leaves us the ability to tweak this in the future but in the meantime allows us to continue discussion as well.
…s, r=oli-obk Add unchecked_shl/shr check for intrinsics to fix miri's test suit r? @RalfJung cc @oli-obk rust-lang#53697 broke miri's test suite as described in [this comment](rust-lang#53697 (comment)). This PR adds test for the `unchecked_shr/shl` for the intrinsics.
…ss-borrowck-to-ui, r=nikomatsakis migrate run-pass/borrowck to ui/run-pass Part of rust-lang#53764
…ss-dirs-to-ui, r=alexcrichton migrate run-pass/*/ to ui/run-pass I think this is all that remains of rust-lang#53764
update clippy submodule updates to cafef7b
|
📌 Commit 87fbf54 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 7, 2018
Rollup of 17 pull requests Successful merges: - #53299 (Updated core/macros.rs to note it works in a no_std environment.) - #53376 (Cross reference io::copy and fs::copy in docs.) - #53455 (Individual docs for {from,to}_*_bytes) - #53550 (librustc_lint: In recursion warning, change 'recurring' to 'recursing') - #53860 (Migrate (some) of run-pass/ to ui) - #53874 (Implement Unpin for Box, Rc, and Arc) - #53895 (tidy: Cleanups and clippy warning fixes) - #53946 (Clarify `ManuallyDrop` docs) - #53948 (Minimized clippy test from when NLL disabled two-phase borrows) - #53959 (Add .git extension to submodule paths missing it) - #53966 (A few cleanups and minor improvements to mir/dataflow) - #53967 (propagate build.python into cmake) - #53979 (Remove `#[repr(transparent)]` from atomics) - #53991 (Add unchecked_shl/shr check for intrinsics to fix miri's test suit) - #53992 (migrate run-pass/borrowck to ui/run-pass) - #53994 (migrate run-pass/*/ to ui/run-pass) - #54023 (update clippy submodule)
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Sep 7, 2018
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ManuallyDropdocs #53946 (ClarifyManuallyDropdocs)#[repr(transparent)]from atomics #53979 (Remove#[repr(transparent)]from atomics)