Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have a travis job that makes sure benchmarks don't break #54176

Open
matthiaskrgr opened this issue Sep 13, 2018 · 1 comment
Open

have a travis job that makes sure benchmarks don't break #54176

matthiaskrgr opened this issue Sep 13, 2018 · 1 comment
Labels

Comments

@matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Sep 13, 2018

I have seen ./x.py bench break several times now, would it be possible to have a ci job run (or cargo check?) the benchmarks once to make sure everything compiles?

@csmoe

This comment has been minimized.

Copy link
Member

@csmoe csmoe commented Sep 13, 2018

If I get your point,

  1. create a /bench task inside src/ci/docker as the existing images like x86_64-gnu did(but with some custom modifications like ENV SCRIPT python2.7 ../x.py bench),
  2. exec ./src/ci/docker/run.sh bench;
  3. don't forget to add bench folder into your local .gitignore.

I saved myself with that when fought with my "dirty" local machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.