Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have a travis job that makes sure benchmarks don't break #54176

Closed
matthiaskrgr opened this issue Sep 13, 2018 · 1 comment · Fixed by #73142
Closed

have a travis job that makes sure benchmarks don't break #54176

matthiaskrgr opened this issue Sep 13, 2018 · 1 comment · Fixed by #73142
Labels
T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@matthiaskrgr
Copy link
Member

I have seen ./x.py bench break several times now, would it be possible to have a ci job run (or cargo check?) the benchmarks once to make sure everything compiles?
@csmoe
Copy link
Member

csmoe commented Sep 13, 2018 •
edited
Loading

If I get your point,

  1. create a /bench task inside src/ci/docker as the existing images like x86_64-gnu did(but with some custom modifications like ENV SCRIPT python2.7 ../x.py bench),
  2. exec ./src/ci/docker/run.sh bench;
  3. don't forget to add bench folder into your local .gitignore.

I saved myself with that when fought with my "dirty" local machine.

@memoryruins memoryruins added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Sep 15, 2018
@ehuss ehuss mentioned this issue Jun 17, 2019
Closed
@ehuss ehuss mentioned this issue Jun 8, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Jun 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#73142 - ehuss:std-benches, r=dtolnay
9688319 
Ensure std benchmarks get tested.

This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot.  Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.

Closes rust-lang#54176
Closes rust-lang#61913
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Jun 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#73142 - ehuss:std-benches, r=dtolnay
4012e45 
Ensure std benchmarks get tested.

This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot.  Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.

Closes rust-lang#54176
Closes rust-lang#61913
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Jun 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#73142 - ehuss:std-benches, r=dtolnay
00315da 
Ensure std benchmarks get tested.

This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot.  Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.

Closes rust-lang#54176
Closes rust-lang#61913
Manishearth added a commit to Manishearth/rust that referenced this issue Jun 16, 2020
@Manishearth
Rollup merge of rust-lang#73142 - ehuss:std-benches, r=dtolnay
d5dc79d 
Ensure std benchmarks get tested.

This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot.  Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.

Closes rust-lang#54176
Closes rust-lang#61913
Manishearth added a commit to Manishearth/rust that referenced this issue Jun 16, 2020
@Manishearth
Rollup merge of rust-lang#73142 - ehuss:std-benches, r=dtolnay
6f2c37a 
Ensure std benchmarks get tested.

This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot.  Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.

Closes rust-lang#54176
Closes rust-lang#61913
tmandry added a commit to tmandry/rust that referenced this issue Jun 17, 2020
@tmandry
Rollup merge of rust-lang#73142 - ehuss:std-benches, r=dtolnay
a37e271 
Ensure std benchmarks get tested.

This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot.  Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.

Closes rust-lang#54176
Closes rust-lang#61913
RalfJung added a commit to RalfJung/rust that referenced this issue Jun 18, 2020
@RalfJung
Rollup merge of rust-lang#73142 - ehuss:std-benches, r=dtolnay
d67e993 
Ensure std benchmarks get tested.

This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot.  Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.

Closes rust-lang#54176
Closes rust-lang#61913
@bors bors closed this as completed in 78f3e9c Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure std benchmarks get tested. ehuss/rust
3 participants
@matthiaskrgr @memoryruins @csmoe