x.py test --no-doc enables testing benchmarks
#61913
Labels
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Comments
ehuss
added
the
T-bootstrap
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Jun 15, 2020
Ensure std benchmarks get tested. This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI. Closes rust-lang#54176 Closes rust-lang#61913
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Jun 15, 2020
Ensure std benchmarks get tested. This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI. Closes rust-lang#54176 Closes rust-lang#61913
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Jun 15, 2020
Ensure std benchmarks get tested. This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI. Closes rust-lang#54176 Closes rust-lang#61913
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Jun 16, 2020
Ensure std benchmarks get tested. This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI. Closes rust-lang#54176 Closes rust-lang#61913
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Jun 16, 2020
Ensure std benchmarks get tested. This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI. Closes rust-lang#54176 Closes rust-lang#61913
tmandry
added a commit
to tmandry/rust
that referenced
this issue
Jun 17, 2020
Ensure std benchmarks get tested. This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI. Closes rust-lang#54176 Closes rust-lang#61913
RalfJung
added a commit
to RalfJung/rust
that referenced
this issue
Jun 18, 2020
Ensure std benchmarks get tested. This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI. Closes rust-lang#54176 Closes rust-lang#61913
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
./x.py test --stage=0 --no-doc src/libcorewill also test the benchmarks in libcore../x.py test --stage=0 src/libcoredoes not test the benchmarks.It is a little surprising that
--no-docwould enable benchmarks. This block of code is responsible for enabling benchmarks.The bigger question is, should benchmarks always be tested? There is a problem that benchmarks are currently not tested on CI, so when they break nobody knows about it (see #54176 and #61816). It could maybe be done with something like
--all-targets, and then--no-docwould stay the same. At least with libcore, it only adds a few seconds to build and run (benchmarks only run one iteration in test mode).The text was updated successfully, but these errors were encountered: