Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The toolstate script is not tested inside CI #56848

Closed
pietroalbini opened this issue Dec 15, 2018 · 0 comments
Closed

The toolstate script is not tested inside CI #56848

pietroalbini opened this issue Dec 15, 2018 · 0 comments
Labels
T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@pietroalbini
Copy link
Member

At the moment we don't test that publish_toolstate.py works on CI. This means if a PR (like #56758) makes a change that breaks the script we don't notice until it breaks master.

We should at least check if the script's syntax is correct on CI, and ideally do a dry run.

cc @rust-lang/infra
@pietroalbini pietroalbini added I-nominated T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 15, 2018
@kennytm kennytm mentioned this issue Dec 15, 2018
Merged
bors added a commit that referenced this issue Dec 27, 2018
@bors
Auto merge of #56852 - kennytm:test-publish-toolstate-in-ci, r=Mark-S…
bc09637 
…imulacrum

Added a job to dry-run the publish_toolstate.py once

Closes #56848.

Requires #56847 to be merged first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pietroalbini