Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a job to dry-run the publish_toolstate.py once #56852

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Dec 15, 2018

Closes #56848.

Requires #56847 to be merged first.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2018
@kennytm kennytm force-pushed the test-publish-toolstate-in-ci branch 3 times, most recently from bb2cd7c to 22aaf63 Compare December 15, 2018 16:13
@rust-highfive

This comment has been minimized.

@kennytm kennytm force-pushed the test-publish-toolstate-in-ci branch 2 times, most recently from 918ecff to 3096a09 Compare December 15, 2018 16:30
@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@kennytm kennytm force-pushed the test-publish-toolstate-in-ci branch 2 times, most recently from 8e1aa49 to bd467bf Compare December 15, 2018 16:55
@kennytm kennytm changed the title [WIP] Dry-run the publish_toolstate.py once inside checktools.sh Added a job to dry-run the publish_toolstate.py once Dec 15, 2018
@kennytm
Copy link
Member Author

kennytm commented Dec 15, 2018

r? @pietroalbini

@kennytm kennytm changed the title Added a job to dry-run the publish_toolstate.py once [DO NOT MERGE] Added a job to dry-run the publish_toolstate.py once Dec 15, 2018
@kennytm kennytm added the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Dec 15, 2018
@pietroalbini
Copy link
Member

r=me once the revert is merged. Thanks!

@kennytm kennytm removed the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Dec 16, 2018
@kennytm kennytm changed the title [DO NOT MERGE] Added a job to dry-run the publish_toolstate.py once Added a job to dry-run the publish_toolstate.py once Dec 16, 2018
@kennytm
Copy link
Member Author

kennytm commented Dec 16, 2018

@bors r=pietroalbini

@bors
Copy link
Contributor

bors commented Dec 16, 2018

📌 Commit 5a7dac840772453bcdf5522681aa8b6e12881165 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2018
@Mark-Simulacrum
Copy link
Member

Could we move this code to the mingw-check builder? I think having more than one "short" builder probably doesn't make too much sense; people in infra meeting seemed to agree.

I'm explicitly not r- this PR though since I think we need the test more than we need this change, so we can land the change in a future PR.

@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 19, 2018
@kennytm
Copy link
Member Author

kennytm commented Dec 19, 2018

@Mark-Simulacrum Moved the code into the before_script: of IMAGE=mingw-check.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 19, 2018

📌 Commit 71d089e736c0ffec395e50fa4ff6c1d1274ed094 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2018
@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0a3a31cf:start=1545236768042540315,finish=1545236826175942975,duration=58133402660
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=mingw-check
---
travis_time:end:03de210e:start=1545236834213525061,finish=1545236834224200670,duration=10675609
travis_fold:end:before_script.2
travis_fold:start:before_script.3
travis_time:start:0f341c28
$ if [ "$IMAGE" = mingw-check ]; then
    # verify the publish_toolstate script works.
    git clone --depth=1 https://github.com/rust-lang-nursery/rust-toolstate.git;
    cd rust-toolstate;
    python2.7 "$TRAVIS_BUILD_DIR/src/tools/publish_toolstate.py" "$(git rev-parse HEAD)" "$(git log --format=%s -n1 HEAD)" "" "";
Cloning into 'rust-toolstate'...
remote: Enumerating objects: 15, done.
remote: Counting objects:   6% (1/15)   
remote: Counting objects:  13% (2/15)   
---
" exited with 0.
travis_time:start:0ae5e8c0
$ stamp sh -x -c "$RUN_SCRIPT"
[00:00:00] +src/ci/init_repo.sh . /home/travis/rustsrc
[00:00:00] sh: 1: src/ci/init_repo.sh: not found
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 127.
travis_time:start:38c919ee
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Wed Dec 19 16:27:14 UTC 2018
---
travis_time:end:027fa558:start=1545236834974710021,finish=1545236834981613990,duration=6903969
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00b3d0d8
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:21815094
travis_time:start:21815094
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:054e4fa8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@pietroalbini
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 19, 2018
@kennytm
Copy link
Member Author

kennytm commented Dec 27, 2018

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Dec 27, 2018

📌 Commit 854abd3 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 27, 2018
@bors
Copy link
Contributor

bors commented Dec 27, 2018

⌛ Testing commit 854abd3 with merge bc09637...

bors added a commit that referenced this pull request Dec 27, 2018
…imulacrum

Added a job to dry-run the publish_toolstate.py once

Closes #56848.

Requires #56847 to be merged first.
@bors
Copy link
Contributor

bors commented Dec 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing bc09637 to master...

@bors bors merged commit 854abd3 into rust-lang:master Dec 27, 2018
@kennytm kennytm deleted the test-publish-toolstate-in-ci branch December 27, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants