Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for str::as_mut_ptr #58215

Open
RalfJung opened this Issue Feb 6, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@RalfJung
Copy link
Member

RalfJung commented Feb 6, 2019

This is a tracking issue for str::as_mut_ptr:

impl str {
    /// Converts a mutable string slice to a raw pointer.
    ///
    /// As string slices are a slice of bytes, the raw pointer points to a
    /// [`u8`]. This pointer will be pointing to the first byte of the string
    /// slice.
    ///
    /// It is your responsibility to make sure that the string slice only gets
    /// modified in a way that it remains valid UTF-8.
    ///
    /// [`u8`]: primitive.u8.html
    pub fn as_mut_ptr(&mut self) -> *mut u8;
}

Implemented in #58200

@SimonSapin

This comment has been minimized.

Copy link
Contributor

SimonSapin commented Feb 6, 2019

Given that the implementation is trivial I don’t think letting it "bake" in Nightly is any use. And since [T] already has this method and str already has the *const version of this, I don’t expect this to be controversial at all. Still, let’s go through the usual dance:

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Feb 6, 2019

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Feb 6, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Feb 16, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.